Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQM: Optimize DQMIO memory use #30889

Merged
merged 2 commits into from
Jul 30, 2020
Merged

DQM: Optimize DQMIO memory use #30889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6128e00
Add a tactical Reset call to save memory.
schneiml Jul 23, 2020
c867554
Add a Refresh() call.
schneiml Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions DQMServices/FwkIO/plugins/DQMRootSource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,10 @@ void DQMRootSource::readElements() {
if (metadata.m_type != kNoTypesStored) {
std::shared_ptr<TreeReaderBase> reader = m_treeReaders[metadata.m_type];
TTree* tree = dynamic_cast<TTree*>(metadata.m_file->Get(kTypeNames[metadata.m_type]));
// The Reset() below screws up the tree, so we need to re-read it from file
// before use here.
tree->Refresh();

reader->setTree(tree);

ULong64_t index = metadata.m_firstIndex;
Expand All @@ -666,6 +670,9 @@ void DQMRootSource::readElements() {
for (; index != endIndex; ++index) {
reader->read(index, edm::Service<DQMStore>().operator->(), metadata.m_run, metadata.m_lumi);
}
// Drop buffers in the TTree. This reduces memory consuption while the tree
// just sits there and waits for the next block to be read.
tree->Reset();
}
}

Expand Down