-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tool to scale SiPixelGainCalibration payloads by including VCal calibration #30880
Conversation
…alibration in them
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30880/17260
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondTools/SiPixel @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@ggovi do you have any comments? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The purpose of this PR is to add a tool in order to produce
SiPixelGainCalibrationForHLT
andSiPixelGainCalibrationOffline
payloads, scaled taking into account that in the Run3 reconstruction the VCal calibration is going to be absorbed into the pixel gain payloads (see details at PR #29333).The formulas to be applied are the following:
PR validation:
Standalone private tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport, and no backport is needed.
cc:
@tvami @tsusa