Add PFCluster validation to ECAL-only and HCAL-only workflows

[fwyzard]

PR description:

Add PFCluster validation to ECAL-only and HCAL-only workflows

PR validation:

Ran the ECAL-only (11634.511) and HCAL-only (11634.521) matrix workflows.

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@cmsbuild, please test workflow 11634.511, 11634.521

[fwyzard]

The almost complete rewrite of Validation/CaloTowers/test/CaloScan/template_2018_since_1010pre2.py is due to the conversion to UNIX-style line endings.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30636/16908

• This PR adds an extra 24KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 11634.521,11634.511
• CMSSW_11_2_X_2020-07-09-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7862/console Started: 2020/07/10 17:01

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Validation/CaloTowers
Validation/Configuration
Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@apsallid, @abdoulline, @rovere, @lecriste, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

@fwyzard
why we have the caloTowers in these HCAL-only or ECAL-only thing ?

[fwyzard]

Mhm, I'm confused...

In Validation/Configuration/python/globalValidation_cff.py I see that we have calotowersValidationSequence only in globalValidationHCAL:

globalValidationHCAL = cms.Sequence(
      hcalSimHitsValidationSequence
    + hcaldigisValidationSequence
    + hcalSimHitStudy
    + hcalRecHitsValidationSequence
    + calotowersValidationSequence
)

and not in globalValidationECALOnly or globalValidationHCALOnly.

In Validation/CaloTowers/test/CaloScan/template_2018_since_1010pre2.py I didn't make any changes about calotowers, though the whole file shows up as changed because of fixing the newlines (I suggest looking at the changes hiding whitespace changes).

However I'm confused because it looks like I am adding globalValidationHCALOnly from scratch, when I thought I only added one module to an existing sequence ?

[cmsbuild]

The code-checks are being triggered in jenkins.

[abdoulline]

Andrea, just one particular aspect: there is no calotowersValidationSequence in globalValidationHCAL anymore: https://github.com/cms-sw/cmssw/pull/30464/files Salavat

…

On Fri, 10 Jul 2020, Andrea Bocci wrote: Mhm, I'm confused... In Validation/Configuration/python/globalValidation_cff.py I see that we have calotowersValidationSequence only in globalValidationHCAL: globalValidationHCAL = cms.Sequence( hcalSimHitsValidationSequence + hcaldigisValidationSequence + hcalSimHitStudy + hcalRecHitsValidationSequence + calotowersValidationSequence ) and not in globalValidationECALOnly or globalValidationHCALOnly. In Validation/CaloTowers/test/CaloScan/template_2018_since_1010pre2.py I didn't make any changes about calotowers, though the whole file shows up as changed because of fixing the newlines (I suggest looking at the changes hiding whitespace changes). However I'm confused because it looks like I am adding globalValidationHCALOnly from scratch, when I thought I only added one module to an existing sequence ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, orunsubscribe.[ABGHJWSVF2LPSWLP2AXMXMDR24S3XA5CNFSM4OWSFF2KYY3PNVWWK3TUL52HS4 DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE4SK2ZI.gif]

[fwyzard]

OK, I've rebased it and now the diff makes more sense ...

[fwyzard]

@abdoulline indeed, looks like I started from a stale branch, and for some reason git did not give me any conflicts.
After rebasing it looks better.

[jfernan2]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1