Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10_6_X] feat: Introduce DeepDoubleX V2 #30542

Merged
merged 1 commit into from
Jul 14, 2020
Merged

[10_6_X] feat: Introduce DeepDoubleX V2 #30542

merged 1 commit into from
Jul 14, 2020

Conversation

andrzejnovak
Copy link
Contributor

PR description:

Backport of #30016 so that it can be added to Nano.

Requires cms-data/RecoBTag-Combined#31

@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Jul 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2020 •
edited
Loading

A new Pull Request was created by @andrzejnovak (Andrzej Novak) for CMSSW_10_6_X.

It involves the following packages:

DataFormats/BTauReco
PhysicsTools/PatAlgos
RecoBTag/FeatureTools
RecoBTag/ONNXRuntime

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @hqucms, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jul 6, 2020

test parameters:

@perrotta
Copy link
Contributor

perrotta commented Jul 6, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/RecoBTag-Combined#31

@cmsbuild cmsbuild mentioned this pull request Jul 6, 2020
Merged
@perrotta
Copy link
Contributor

perrotta commented Jul 6, 2020

@andrzejnovak let see if tests succeed anyhow. The external should be also submitted for the 10_6 branch, however

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

+1
Tested at: 51f2370
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-666362/7703/summary.html
CMSSW: CMSSW_10_6_X_2020-07-05-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

Comparison job queued.

@andrzejnovak
Copy link
Contributor Author

andrzejnovak commented Jul 6, 2020 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-666362/7703/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214558
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214223
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

@mrodozov : the following externals, already merged in the master, should also become available in 10_6 if version V2 of DeepDoubleX has to be run:

Is that something you can take care of? Thank you!

@mrodozov
Copy link
Contributor

test parameters:

@mrodozov
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6067

@cmsbuild cmsbuild mentioned this pull request Jul 13, 2020
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 16ad510
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9787d/7900/summary.html
CMSSW: CMSSW_10_6_X_2020-07-13-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9787d/7900/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214618
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214283
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 610d6aa into cms-sw:CMSSW_10_6_X Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
analysis-approved backport-ok comparison-available fully-signed orp-approved reconstruction-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_10_6_X
Development

Successfully merging this pull request may close these issues.
6 participants
@andrzejnovak @cmsbuild @perrotta @mrodozov @santocch @silviodonato