-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx251 Add the algorithm for next version of HGCal geometry description #30486
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30486/16661
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30486/16663
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Comparison is ready Comparison Summary:
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
if (u < 0) | ||
copy += 10000; | ||
if (v < 0) | ||
copy += 100000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this code is migrated to DD4hep, these magic numbers (1e4, 1e5, 1e6) should be turned into constants.
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add the algorithm for next version of HGCal geometry description (only DDD version is added now; DD4Hep version will be added next)
PR validation:
Tested using runTheMatrix.py. The dumped geometry using a private cfg is tested for overlaps
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special