-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pixel 3D Digitizer] Fix wrong channel assignation #30446
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30446/16568
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30446/16569
|
A new Pull Request was created by @duartej (Jordi Duarte Campderros) for master. It involves the following packages: SimTracker/SiPhase2Digitizer @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
@duartej cmssw/SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc Lines 1515 to 1523 in 518b6ef
in any case in the phase1 case the class |
ahh, yes, you are right. I can see it is using the pixelToChannel function there as well. However, regarding the |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fix bug in channel assignation, by using
PixelDigi::pixelToChannel
function instead ofPixelTopology::channel
.@emiglior and @skinnari as conveners of the upgrade simulation group are aware and agree.
cc: @suchandradutta
PR validation:
This PR is affecting the Phase 2 upgrade 3D geometry only, checked with workflows 26234.0 and 24834.0 succesfully.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport