-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the MadGraph bug for multithreading (backport #30444) #30445
Conversation
A bug was recently observed in the madgraph multithread mode that influence the calculated xsec: https://bugs.launchpad.net/mg5amcnlo/+bug/1884085 To fix this, We add additional patches to the madgraph code when producing events from earlier gridpacks.
A new Pull Request was created by @colizz (Congqiao Li) for CMSSW_10_6_X. It involves the following packages: GeneratorInterface/LHEInterface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a backport from #30444
PR validation:
The fix is on shell scripts, hence does not influence the CMSSW framework.
We tested the scripts on W+01234j and DY+01234j multi-jet processes to validate that the MG bug is solved.
(A quick test for this PR on
SMP-MultiValidationUL17wmLHEGEN-00001
)