Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply the "const" modifier to the return type (11.1.x) #30002

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 27, 2020

PR description:

Fixes the warning

CondFormats/EcalObjects/interface/EcalXtalGroupId.h(22): warning: type qualifier on return type is meaningless

No changes expected.

If this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #29913 to avoid conflicts when squashing or rebasing the Patatrack developments.

Fixes the warning

    CondFormats/EcalObjects/interface/EcalXtalGroupId.h(22):
    warning: type qualifier on return type is meaningless
@fwyzard
Copy link
Contributor Author

fwyzard commented May 27, 2020

backport #29913

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X.

It involves the following packages:

CondFormats/EcalObjects

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@rchatter, @mmusich, @seemasharmafnal, @tocheng, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@pohsun
Copy link

pohsun commented May 28, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6631/console Started: 2020/05/28 09:12

@cmsbuild
Copy link
Contributor

+1
Tested at: aba0abc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c2f40/6631/summary.html
CMSSW: CMSSW_11_1_X_2020-05-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c2f40/6631/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780694
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@pohsun
Copy link

pohsun commented May 29, 2020

+1

@silviodonato
Copy link
Contributor

merge
cc: @ggovi

@cmsbuild cmsbuild merged commit 82d505a into cms-sw:CMSSW_11_1_X Jun 1, 2020
@fwyzard fwyzard deleted the patatrack_remove_const_on_return branch July 13, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants