-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiPixelClusterProducer: apply gain calibration scheme update at HLT as well #29951
SiPixelClusterProducer: apply gain calibration scheme update at HLT as well #29951
Conversation
type bug-fix |
urgent |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29951/15600
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: HLTrigger/Configuration @cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
e4cefbe
to
1afecc5
Compare
-1 Tested at: 1afecc5 CMSSW: CMSSW_11_1_X_2020-05-22-1100 I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Unfortunately the Pixel gain calibration scheme update introduced at #29333 missed the HLT configuration.
This PR provides the appropriate customization function to deal with the update of conditions also for the HLT.
PR validation:
Dumped the step3 configuration of https://cmsweb.cern.ch/couchdb/reqmgr_config_cache/95d680704ae17507a77b0e3350c8c1d5/configFile with and without this branch and obtained as expected:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport.
cc: @tsusa @dkotlins @tvami