-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuildFile cleanup: removed unnecessary dependencies #29608
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29608/14944
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: CondFormats/EcalObjects @benkrikler, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @rekovic, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29608/14946
|
Pull request #29608 was updated. @perrotta, @benkrikler, @slava77, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @rekovic, @tocheng, @tlampen, @ggovi, @pohsun can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@silviodonato , can we get this merged. It is mostly dependency cleanup. This should allow us to build CXXMODULE IBs |
merge |
PR description:
Remove unnecessary dependencies from BuildFiles. This also help CXX Module IBs dependency issue.
FYI @davidlange6 , @vgvassilev
PR validation:
Local build was successful