Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildFile cleanup: removed unnecessary dependencies #29608

Merged
merged 2 commits into from
May 1, 2020
Merged

BuildFile cleanup: removed unnecessary dependencies #29608

merged 2 commits into from
May 1, 2020

Conversation

smuzaffar
Copy link
Contributor

PR description:

Remove unnecessary dependencies from BuildFiles. This also help CXX Module IBs dependency issue.
FYI @davidlange6 , @vgvassilev

PR validation:

Local build was successful

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29608/14944

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondFormats/EcalObjects
CondTools/Ecal
DataFormats/L1TMuon
L1Trigger/L1TTwinMux
SimDataFormats/PileupSummaryInfo

@benkrikler, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @rekovic, @tocheng, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@thomreis, @battibass, @rovere, @argiro, @Martin-Grunewald, @apsallid, @tocheng, @lecriste, @mmusich, @fabiocos, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29608/14946

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

Pull request #29608 was updated. @perrotta, @benkrikler, @slava77, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @rekovic, @tocheng, @tlampen, @ggovi, @pohsun can you please check and sign again.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 30, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5936/console Started: 2020/04/30 22:27

@cmsbuild
Copy link
Contributor

+1
Tested at: b46953d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d09e11/5936/summary.html
CMSSW: CMSSW_11_1_X_2020-04-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d09e11/5936/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 1, 2020

+1

for #29608 b46953d

  • technical
  • jenkins tests pass

@civanch
Copy link
Contributor

civanch commented May 1, 2020

+1

@smuzaffar
Copy link
Contributor Author

@silviodonato , can we get this merged. It is mostly dependency cleanup. This should allow us to build CXXMODULE IBs

@silviodonato
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants