-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add track filter for N tracks with minimum pt #29604
add track filter for N tracks with minimum pt #29604
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/14941
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@antoniovagnerini thanks ! |
@mtosi thank you, this is a good point. For the moment, this only performs a cut on the track candidate pT, but in principle one can add in the Fill Description template some extra parameters. I will have a look. |
these have to be addressed before other tests can run |
@antoniovagnerini |
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15338
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29604/15340
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@cmsbuild please abort test |
Jenkins tests are aborted. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
@antoniovagnerini have you consider to use a generic https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuidePhysicsCutParser
|
The idea of this PR was to introduce an ED filter specifically for tracks, enabling pT and other cut variables. As discussed in #21241, this kind of approach is needed for Cosmic During Collision track reconstruction. |
+1 |
EDFilter to be used in the cosmics during collision (CDC) trigger @HLT
It selects N tracks passing a certain pT cut.
This PR is a follow-up of the PR #21241 and it uses the template approach suggested previously.