[LLVM10] Fixing compilation warnings for Reco2 #29572

smuzaffar · 2020-04-28T13:33:54Z

PR description:

LLVM 10 integration in CLANG IBs shows new compilation warnings. This PR fixes few of these from reconstruction packages

Avoid creating loop variable copy
fix implicit conversion warnings

PR validation:

Local compilation for CLANG and normal IBs show no warnings.

cmsbuild · 2020-04-28T13:34:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-28T13:42:57Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29572/14881

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoBTag/TensorFlow/plugins/DeepVertexTFJetTagsProducer.cc modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc modified in PR(s): [LLVM10] Fixing compilation warnings for Reco and SIM #29568

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29572/14881/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29572/14881/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-04-28T13:51:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-28T13:56:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29572/14882

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoBTag/TensorFlow/plugins/DeepVertexTFJetTagsProducer.cc modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172
- File RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc modified in PR(s): [LLVM10] Fixing compilation warnings for Reco and SIM #29568

cmsbuild · 2020-04-28T13:56:55Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CommonTools/RecoAlgos
EventFilter/RPCRawToDigi
RecoBTag/TensorFlow
RecoLocalTracker/SiStripClusterizer
RecoMuon/MuonIdentification
TrackingTools/DetLayers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @felicepantaleo, @yduhm, @robervalwalsh, @emilbols, @echapon, @ahinzmann, @threus, @mmusich, @cericeci, @calderona, @makortel, @smoortga, @jhgoh, @jdolen, @HuguesBrun, @ferencek, @pieterdavid, @rociovilar, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gkasieczka, @hatakeyamak, @alesaggio, @ebrondol, @dgulhan, @clelange, @Martin-Grunewald, @trocino, @riga, @gbenelli, @Fedespring, @JyothsnaKomaragiri, @mverzett, @lecriste, @gpetruc, @andrzejnovak, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2020-04-28T21:39:54Z

please test

cmsbuild · 2020-04-28T21:40:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5892/console Started: 2020/04/28 23:41

cmsbuild · 2020-04-28T22:56:49Z

+1
Tested at: 8503411
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a8d1c/5892/summary.html
CMSSW: CMSSW_11_1_X_2020-04-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-28T22:56:51Z

Comparison job queued.

cmsbuild · 2020-04-29T03:02:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a8d1c/5892/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696435
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696114
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

cmsbuild · 2020-04-30T09:53:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29572/14931

This PR adds an extra 60KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoBTag/TensorFlow/plugins/DeepVertexTFJetTagsProducer.cc modified in PR(s): Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172

cmsbuild · 2020-04-30T09:53:38Z

Pull request #29572 was updated. @perrotta, @cmsbuild, @civanch, @mdhildreth, @slava77 can you please check and sign again.

smuzaffar · 2020-04-30T09:56:06Z

please test

cmsbuild · 2020-04-30T09:56:28Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5924/console Started: 2020/04/30 12:02

cmsbuild · 2020-04-30T11:49:37Z

+1
Tested at: 69fe774
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a8d1c/5924/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-30T11:49:40Z

Comparison job queued.

cmsbuild · 2020-04-30T13:23:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a8d1c/5924/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696435
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696114
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

slava77 · 2020-04-30T21:05:58Z

+1

for #29572 69fe774

technical; code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show no (relevant) differences

civanch · 2020-05-01T12:03:27Z

+1

cmsbuild · 2020-05-01T12:03:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-05-01T12:38:12Z

+1

cmsbuild added this to the CMSSW_11_1_X milestone Apr 28, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 28, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Apr 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 28, 2020

cmsbuild mentioned this pull request Apr 28, 2020

[LLVM10] Fixing compilation warnings for Reco and SIM #29568

Closed

cmsbuild added tests-started and removed tests-pending labels Apr 28, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 29, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 30, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 30, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 30, 2020

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels May 1, 2020

cmsbuild added orp-approved and removed orp-pending labels May 1, 2020

cmsbuild merged commit 372abd5 into cms-sw:master May 1, 2020

This was referenced May 1, 2020

Extend ConfigBuilder to properly handle special import handling #29611

Merged

initialize std::array data member in TICLCandidate #29616

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLVM10] Fixing compilation warnings for Reco2 #29572

[LLVM10] Fixing compilation warnings for Reco2 #29572

smuzaffar commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

smuzaffar commented Apr 28, 2020

cmsbuild commented Apr 28, 2020 •

edited

Loading

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 29, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

smuzaffar commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 •

edited

Loading

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

slava77 commented Apr 30, 2020

civanch commented May 1, 2020

cmsbuild commented May 1, 2020

silviodonato commented May 1, 2020

[LLVM10] Fixing compilation warnings for Reco2 #29572

[LLVM10] Fixing compilation warnings for Reco2 #29572

Conversation

smuzaffar commented Apr 28, 2020

PR description:

PR validation:

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

smuzaffar commented Apr 28, 2020

cmsbuild commented Apr 28, 2020 • edited Loading

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 29, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

smuzaffar commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 • edited Loading

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

slava77 commented Apr 30, 2020

civanch commented May 1, 2020

cmsbuild commented May 1, 2020

silviodonato commented May 1, 2020

cmsbuild commented Apr 28, 2020 •

edited

Loading

cmsbuild commented Apr 30, 2020 •

edited

Loading