Backport of inverse beta variable in pat::Muons for 10_6_X

[cericeci]

PR description:

This is a (long overdue) backport of #28212 to 10_6_X in order to save the inverse beta (timing variable) of pat::muons. We discussed this-very briefly- this in a reco meeting a couple of months ago. As it's been some time should I raise it again next time?

Our goal would be to have it as part of a possible UL re-miniAOD. Should I also comment on issue #27889 ?

PR validation:

Same tests as the original PR:
No compilation errors or of battery of tests from
runTheMatrix.py -l limited -i all

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #28212 to include the feature in reminiAOD of UL

[cmsbuild]

A new Pull Request was created by @cericeci (Carlos Erice) for CMSSW_10_6_X.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Propagate inverse beta variable to pat muons (muon POG) #28212

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5413/console Started: 2020/03/27 18:18

[slava77]

Our goal would be to have it as part of a possible UL re-miniAOD. Should I also comment on issue #27889 ?

sure, please. Thank you.

[perrotta]

backport of #28212

[cmsbuild]

+1
Tested at: ae74db1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32a58d/5413/summary.html
CMSSW: CMSSW_10_6_X_2020-03-27-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32a58d/5413/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 35
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211955
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[santocch]

+1

[cmsbuild]

Pull request #29324 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

[cericeci]

Either the master needs an update first or this PR needs an update to re-introduce addInverseBeta

I reintroduced addInverseBeta back again, in fact I checked out the files back from the previous (rebased from master) commit. I was overzealous in removing the effects of the reminiAOD era modifier.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5689/console Started: 2020/04/14 17:53

[cmsbuild]

+1
Tested at: 9347528
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32a58d/5689/summary.html
CMSSW: CMSSW_10_6_X_2020-04-14-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32a58d/5689/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211975
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #29324 9347528

• the backport is now consistent with the master version of Propagate inverse beta variable to pat muons (muon POG) #28212 . Since this adds a new variable to the pat::Muon, I think that it should be fine to fill it as in the master version, without additional modifiers to disable filling by default.
• jenkins tests pass and comparisons show no [relevant] differences (old/existing variables are not affected)

[silviodonato]

do you have comments @santocch?

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1