-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python3 problems with #28920 #29219
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29219/14237
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Configuration/Applications @cmsbuild, @silviodonato, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
Comparison job queued. |
It may be an error in python3 but it’s a bug also in python 2
Probably worth knowing the impact of that bug
On 17 Mar 2020, at 19:44, Silvio Donato <notifications@github.com> wrote:
As discussed during the Core software meeting, we can trivially fix the failures in PY3 IB by forcing int(self._options.nConcurrentLumis).
The error affecting almost all workflows in CMSSW_11_1_PY3_X_2020-03-16-2300 was
File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 56, in <module>
run()
File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/bin/slc7_amd64_gcc820/cmsDriver.py", line 28, in run
configBuilder.prepare()
File "/cvmfs/cms-ib.cern.ch/nweek-02620/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_1_PY3_X_2020-03-16-2300/python/Configuration/Applications/ConfigBuilder.py", line 2235, in prepare
if self._options.nConcurrentLumis > 1:
TypeError: '>' not supported between instances of 'str' and 'int'```
This bug was related to #28920.
…________________________________
You can view, comment on, or merge this pull request online at:
#29219
Commit Summary
* fix py3 compatib
File Changes
* M Configuration/Applications/python/ConfigBuilder.py<https://github.com/cms-sw/cmssw/pull/29219/files#diff-05daab1ca94b26f7bab27d1187d95415> (2)
Patch Links:
* https://github.com/cms-sw/cmssw/pull/29219.patch
* https://github.com/cms-sw/cmssw/pull/29219.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#29219>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ7ZULUATTEC6NZD5WTRH7AIJANCNFSM4LNXLFXA>.
|
merge cc: @schneiml |
Comparison is ready Comparison Summary:
|
As discussed during the Core software meeting, we can trivially fix the failures in PY3 IB by forcing
int(self._options.nConcurrentLumis)
.The error affecting almost all workflows in CMSSW_11_1_PY3_X_2020-03-16-2300 was