Added features to list laser runs extracted from DB. Added dictionary classes for laser DB handling #29196
Conversation
…classes and script IODConfig.h updated to get rid of Oracle specific message parsing: using a more general method
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29196/14171
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29196/14172
|
|
A new Pull Request was created by @organtin (Giovanni Organtini) for master. It involves the following packages: OnlineDB/EcalCondDB @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
Kind reminder to @ggovi |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
db-approved
fully-signed
and removed
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@organtin https://github.com/cms-sw/cmssw/pull/29196/files shows no changes... what is going on? |
|
Well, I must confess that I do not fully understand the process of a pull
request. I committed few changes to the code following instructions on
https://cms-sw.github.io/PRWorkflow.html
After a first pull request I was notified that the code were not compliant
with coding rules (in fact the affected files were untouched by myself). I
then modified the files to make them compliant and, in the meantime, I
received a request from laser developers to wait for further possible
changes. The initial pull request was closed.
After some time I got the green light from the laser team and I resubmitted
a pull request (that should be this one).
Am I supposed to take some action?
Thank you for your patience.
…On Tue, 17 Mar 2020 at 10:53, Silvio Donato ***@***.***> wrote:
@organtin <https://github.com/organtin>
https://github.com/cms-sw/cmssw/pull/29196/files shows no changes... what
is going on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDYKCETW37EWFW6KP7BQOLRH5B7VANCNFSM4LGPO7PA>
.
--
Giovanni Organtini
Dip. di Fisica Sapienza Universita' di Roma & INFN-Sez. di Roma
P.le A. Moro 2 - 00185 Roma (Tel. +39.06.4991.4329 Fax: +39.06.4453.829)
|
|
@organtin I don't know what happened. In any case, the current file in CMSSW is https://github.com/cms-sw/cmssw/blob/master/OnlineDB/EcalCondDB/interface/IODConfig.h Perhaps you made a PR from the wrong branch (see master...organtin:GOFC-new-features ) |
|
Thank you for your support. Indeed, I just verified that the two relevant
files were not in my commit :-(
I was sure I made the commit, but probably, as you pointed it out, I made
it on the wrong branch...I committed them now. The two files added are
OnlineDB/EcalCondDB/src/classes.h
OnlineDB/EcalCondDB/src/classes_def.xml
Do I need to submit a new pull request or can you go ahead with this?
…On Tue, 17 Mar 2020 at 14:34, Silvio Donato ***@***.***> wrote:
@organtin <https://github.com/organtin> I don't know what happened. In
any case, the current file in CMSSW is
https://github.com/cms-sw/cmssw/blob/master/OnlineDB/EcalCondDB/interface/IODConfig.h
and the file in your area is
https://github.com/organtin/cmssw/blob/GOFC-new-branch/OnlineDB/EcalCondDB/interface/IODConfig.h
.
Excluding two empty lines, there are no differences ...
Perhaps you made a PR from the wrong branch (see
master...organtin:GOFC-new-features
<master...organtin:GOFC-new-features>
)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDYKCAPB6ZTFXX442GIWZ3RH535LANCNFSM4LGPO7PA>
.
--
Giovanni Organtini
Dip. di Fisica Sapienza Universita' di Roma & INFN-Sez. di Roma
P.le A. Moro 2 - 00185 Roma (Tel. +39.06.4991.4329 Fax: +39.06.4453.829)
|
|
@organtin you can either update the branch organtin:GOFC-new-branch or you can create a pull request. Perhaps it is simpler to create a new PR. |
|
hold |
|
Pull request has been put on hold by @silviodonato |
|
I submitted a new pull request to merge the content of
the GOFC-dictionary-classes-added branch. You can delete this.
…On Wed, 18 Mar 2020 at 09:51, cmsbuild ***@***.***> wrote:
Pull request has been put on hold by @silviodonato
<https://github.com/silviodonato>
They need to issue an unhold command to remove the hold state or L1 can
unhold it for all
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDYKCEXXXTIBMONAHIAGWDRICDRJANCNFSM4LGPO7PA>
.
--
Giovanni Organtini
Dip. di Fisica Sapienza Universita' di Roma & INFN-Sez. di Roma
P.le A. Moro 2 - 00185 Roma (Tel. +39.06.4991.4329 Fax: +39.06.4453.829)
|
|
moved to #29240 |
…classes and script
IODConfig.h updated to get rid of Oracle specific message parsing: using a more general method
PR description:
New dictionary classes added to help DB consultation for laser analysis. Fabrice COUDERC provided the dictionary classes classes.h and classes_def.xml.
The interface file IODConfig.h was updated to take into account changes in Oracle libraries.
PR validation:
Run
scram b code-checks
scram b runtests
runTheMatrix.py -l limited -i all --ibeos
specific tests designed by FC successfull
if this PR is a backport please specify the original PR and why you need to backport that PR: