-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance formatting of special geometry test #29189
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29189/14160
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: CondTools/Geometry @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Kind reminder to @ggovi |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
A special geometry test is used by experts to compare geometry descriptions in different formats, e.g. in a local database and in the Conditions database. This PR enhances the output of this test. First, floating-point values close to zero are rounded to zero to prevent minor fluctuations of very tiny values from showing up as differences. Second, each line is labeled with a sub-detector name so it is easier to identify differences between two geometry descriptions.
Further improvements in this test might be desirable. It is still vulnerable to re-arrangements of identical descriptions.
This test is not used in production or in unit tests.
PR validation:
Test output is now somewhat easier to read.