-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCAL: TDC simulation fix #29083
HCAL: TDC simulation fix #29083
Conversation
@lwang046, CMSSW_11_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29083/13971
|
A new Pull Request was created by @lwang046 for master. It involves the following packages: SimCalorimetry/HcalSimAlgos @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
it would be nice to have this merged soon, assuming this actually fixes the random differences in DQM comparisons |
@civanch @silviodonato may we get it merged, please? |
@civanch @mdhildreth could you have a look to this PR? |
merge |
PR description:
This PR is a fix to the Hcal DQM issue in #29076 which was revealed by #29035 after change Hcal frame size from 8 to 10. The previous code was hardcoded for 8 TS case in run2. The change adjust the sample size automatically.