-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use of replaced Configuration/Geometry/DD4hep_GeometrySim_cff fragment #28922
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28922/13719
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/StandardSequences @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
bug-fix |
type bug-fix |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
urgent |
+1 |
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
In #28847
Configuration.Geometry.DD4hep_GeometrySim_cff
has been renamed to a more standardGeometryDD4hepExtended2021_cff
to allow developers to use it withcmsDriver.py
. This PR fixes the two residual places where this update has not been propagated.PR validation:
Code compiles,
validateGEMGeometry_cfg.py
does not complain any more because of the missing fragment (but it fails for apparently unrelated issues, @slomeo FYI).