MTD TDR Reconstruction + MTD Track Association BDT #28815
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| from RecoMTD.TrackExtender.trackExtenderWithMTD_cfi import * | ||
| from RecoMTD.TimingIDTools.mtdTrackQualityMVA_cfi import * | ||
|
|
||
| fastTimingGlobalRecoTask = cms.Task(trackExtenderWithMTD,mtdTrackQualityMVA) | ||
| fastTimingGlobalReco = cms.Sequence(fastTimingGlobalRecoTask) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <use name="FWCore/Framework"/> | ||
| <use name="FWCore/ParameterSet"/> | ||
| <use name="DataFormats/TrackReco"/> | ||
| <use name="DataFormats/BeamSpot"/> | ||
| <use name="DataFormats/RecoCandidate"/> | ||
| <use name="DataFormats/Candidate"/> | ||
| <use name="DataFormats/VertexReco"/> | ||
| <use name="CommonTools/MVAUtils"/> | ||
|
|
||
| <export> | ||
| <lib name="1"/> | ||
| </export> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| #ifndef RECOMTD_TIMINGIDTOOLS_MTDTRACKQUALITYMVA | ||
| #define RECOMTD_TIMINGIDTOOLS_MTDTRACKQUALITYMVA | ||
|
|
||
| #include "DataFormats/VertexReco/interface/Vertex.h" | ||
| #include "DataFormats/VertexReco/interface/VertexFwd.h" | ||
| #include "DataFormats/TrackReco/interface/Track.h" | ||
| #include "DataFormats/TrackReco/interface/TrackFwd.h" | ||
| #include "DataFormats/Common/interface/ValueMap.h" | ||
|
|
||
| #include "CommonTools/MVAUtils/interface/TMVAEvaluator.h" | ||
|
|
||
| #define MTDTRACKQUALITYMVA_VARS(MTDBDTVAR) \ | ||
| MTDBDTVAR(pt) \ | ||
|
There was a problem hiding this comment. the arguments didn't need to have MTD in the prefix, but it's fine. |
||
| MTDBDTVAR(eta) \ | ||
| MTDBDTVAR(phi) \ | ||
| MTDBDTVAR(chi2) \ | ||
| MTDBDTVAR(ndof) \ | ||
| MTDBDTVAR(numberOfValidHits) \ | ||
| MTDBDTVAR(numberOfValidPixelBarrelHits) \ | ||
| MTDBDTVAR(numberOfValidPixelEndcapHits) \ | ||
| MTDBDTVAR(btlMatchChi2) \ | ||
| MTDBDTVAR(btlMatchTimeChi2) \ | ||
| MTDBDTVAR(etlMatchChi2) \ | ||
| MTDBDTVAR(etlMatchTimeChi2) \ | ||
| MTDBDTVAR(mtdt) \ | ||
| MTDBDTVAR(path_len) | ||
|
|
||
| #define MTDBDTVAR_ENUM(ENUM) ENUM, | ||
| #define MTDBDTVAR_STRING(STRING) #STRING, | ||
|
|
||
| class MTDTrackQualityMVA { | ||
| public: | ||
| //---ctors--- | ||
| MTDTrackQualityMVA(std::string weights_file); | ||
|
|
||
| enum class VarID { MTDTRACKQUALITYMVA_VARS(MTDBDTVAR_ENUM) }; | ||
|
|
||
| //---getters--- | ||
| // 4D | ||
| float operator()(const reco::TrackRef& trk, | ||
| const reco::TrackRef& ext_trk, | ||
| const edm::ValueMap<float>& btl_chi2s, | ||
| const edm::ValueMap<float>& btl_time_chi2s, | ||
| const edm::ValueMap<float>& etl_chi2s, | ||
| const edm::ValueMap<float>& etl_time_chi2s, | ||
| const edm::ValueMap<float>& tmtds, | ||
| const edm::ValueMap<float>& trk_lengths) const; | ||
|
|
||
| private: | ||
| std::vector<std::string> vars_, spec_vars_; | ||
| std::unique_ptr<TMVAEvaluator> mva_; | ||
| }; | ||
|
|
||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <library name="RecoMTDTimingIDTools_plugins" file="*.cc"> | ||
| <use name="FWCore/Framework"/> | ||
|
There was a problem hiding this comment. IIUC, all "use" statements can be outside of the "library" section. shouldn't there be a @makortel @smuzaffar is this flag not needed anymore? There was a problem hiding this comment. @slava77 , in Yes the |
||
| <use name="FWCore/ParameterSet"/> | ||
| <use name="DataFormats/TrackReco"/> | ||
| <use name="DataFormats/BeamSpot"/> | ||
| <use name="DataFormats/RecoCandidate"/> | ||
| <use name="DataFormats/Candidate"/> | ||
| <use name="DataFormats/VertexReco"/> | ||
| <use name="CommonTools/MVAUtils"/> | ||
| <use name="RecoMTD/TimingIDTools"/> | ||
| </library> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| #include "FWCore/Framework/interface/Frameworkfwd.h" | ||
| #include "FWCore/Framework/interface/stream/EDProducer.h" | ||
| #include "FWCore/Framework/interface/Event.h" | ||
| #include "FWCore/Framework/interface/EventSetup.h" | ||
| #include "FWCore/Framework/interface/ESHandle.h" | ||
| #include "FWCore/ParameterSet/interface/ParameterSet.h" | ||
| #include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h" | ||
|
|
||
| #include "DataFormats/VertexReco/interface/VertexFwd.h" | ||
| #include "DataFormats/TrackReco/interface/TrackFwd.h" | ||
| #include "DataFormats/Common/interface/ValueMap.h" | ||
| #include "DataFormats/BeamSpot/interface/BeamSpot.h" | ||
| #include "DataFormats/TrackReco/interface/Track.h" | ||
| #include "DataFormats/VertexReco/interface/Vertex.h" | ||
|
|
||
| #include "RecoMTD/TimingIDTools/interface/MTDTrackQualityMVA.h" | ||
|
|
||
| using namespace std; | ||
| using namespace edm; | ||
|
|
||
| class MTDTrackQualityMVAProducer : public edm::stream::EDProducer<> { | ||
| public: | ||
| MTDTrackQualityMVAProducer(const ParameterSet& pset); | ||
|
|
||
| static void fillDescriptions(edm::ConfigurationDescriptions& descriptions); | ||
|
|
||
| template <class H, class T> | ||
| void fillValueMap(edm::Event& iEvent, | ||
| const edm::Handle<H>& handle, | ||
| const std::vector<T>& vec, | ||
| const std::string& name) const; | ||
|
|
||
| void produce(edm::Event& ev, const edm::EventSetup& es) final; | ||
|
|
||
| private: | ||
| static constexpr char mvaName[] = "mtdQualMVA"; | ||
|
|
||
| edm::EDGetTokenT<reco::TrackCollection> tracksToken_; | ||
| edm::EDGetTokenT<reco::TrackCollection> tracksMTDToken_; | ||
|
|
||
| edm::EDGetTokenT<edm::ValueMap<float>> btlMatchChi2Token_; | ||
| edm::EDGetTokenT<edm::ValueMap<float>> btlMatchTimeChi2Token_; | ||
| edm::EDGetTokenT<edm::ValueMap<float>> etlMatchChi2Token_; | ||
| edm::EDGetTokenT<edm::ValueMap<float>> etlMatchTimeChi2Token_; | ||
| edm::EDGetTokenT<edm::ValueMap<float>> mtdTimeToken_; | ||
| edm::EDGetTokenT<edm::ValueMap<float>> pathLengthToken_; | ||
| edm::EDGetTokenT<edm::ValueMap<int>> trackAssocToken_; | ||
|
|
||
| MTDTrackQualityMVA mva_; | ||
| }; | ||
|
|
||
| MTDTrackQualityMVAProducer::MTDTrackQualityMVAProducer(const ParameterSet& iConfig) | ||
| : tracksToken_(consumes<reco::TrackCollection>(iConfig.getParameter<edm::InputTag>("tracksSrc"))), | ||
| tracksMTDToken_(consumes<reco::TrackCollection>(iConfig.getParameter<edm::InputTag>("tracksMTDSrc"))), | ||
| btlMatchChi2Token_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("btlMatchChi2Src"))), | ||
| btlMatchTimeChi2Token_( | ||
| consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("btlMatchTimeChi2Src"))), | ||
| etlMatchChi2Token_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("etlMatchChi2Src"))), | ||
| etlMatchTimeChi2Token_( | ||
| consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("etlMatchTimeChi2Src"))), | ||
| mtdTimeToken_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("mtdTimeSrc"))), | ||
| pathLengthToken_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("pathLengthSrc"))), | ||
| trackAssocToken_(consumes<edm::ValueMap<int>>(iConfig.getParameter<edm::InputTag>("trackAssocSrc"))), | ||
| mva_(iConfig.getParameter<edm::FileInPath>("qualityBDT_weights_file").fullPath()) { | ||
| produces<edm::ValueMap<float>>(mvaName); | ||
| } | ||
|
|
||
| // Configuration descriptions | ||
| void MTDTrackQualityMVAProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) { | ||
| edm::ParameterSetDescription desc; | ||
| desc.add<edm::InputTag>("tracksSrc", edm::InputTag("generalTracks"))->setComment("Input tracks collection"); | ||
| desc.add<edm::InputTag>("tracksMTDSrc", edm::InputTag("trackExtenderWithMTD")) | ||
| ->setComment("Input tracks collection for MTD extended tracks"); | ||
| desc.add<edm::InputTag>("btlMatchChi2Src", edm::InputTag("trackExtenderWithMTD", "btlMatchChi2")) | ||
| ->setComment("BTL Chi2 Matching value Map"); | ||
| desc.add<edm::InputTag>("btlMatchTimeChi2Src", edm::InputTag("trackExtenderWithMTD", "btlMatchTimeChi2")) | ||
| ->setComment("BTL Chi2 Matching value Map"); | ||
| desc.add<edm::InputTag>("etlMatchChi2Src", edm::InputTag("trackExtenderWithMTD", "etlMatchChi2")) | ||
| ->setComment("ETL Chi2 Matching value Map"); | ||
| desc.add<edm::InputTag>("etlMatchTimeChi2Src", edm::InputTag("trackExtenderWithMTD", "etlMatchTimeChi2")) | ||
| ->setComment("ETL Chi2 Matching value Map"); | ||
| desc.add<edm::InputTag>("mtdTimeSrc", edm::InputTag("trackExtenderWithMTD", "tmtd")) | ||
| ->setComment("MTD TIme value Map"); | ||
| desc.add<edm::InputTag>("pathLengthSrc", edm::InputTag("trackExtenderWithMTD", "pathLength")) | ||
| ->setComment("MTD PathLength value Map"); | ||
| desc.add<edm::InputTag>("trackAssocSrc", edm::InputTag("trackExtenderWithMTD", "generalTrackassoc")) | ||
| ->setComment("Association between General and MTD Extended tracks"); | ||
| desc.add<edm::FileInPath>("qualityBDT_weights_file", | ||
| edm::FileInPath("RecoMTD/TimingIDTools/data/clf4D_MTDquality_bo.xml")) | ||
| ->setComment("Track MTD quality BDT weights"); | ||
| descriptions.add("mtdTrackQualityMVAProducer", desc); | ||
| } | ||
|
|
||
| template <class H, class T> | ||
| void MTDTrackQualityMVAProducer::fillValueMap(edm::Event& iEvent, | ||
| const edm::Handle<H>& handle, | ||
| const std::vector<T>& vec, | ||
| const std::string& name) const { | ||
| auto out = std::make_unique<edm::ValueMap<T>>(); | ||
| typename edm::ValueMap<T>::Filler filler(*out); | ||
| filler.insert(handle, vec.begin(), vec.end()); | ||
| filler.fill(); | ||
| iEvent.put(std::move(out), name); | ||
| } | ||
|
|
||
| void MTDTrackQualityMVAProducer::produce(edm::Event& ev, const edm::EventSetup& es) { | ||
| edm::Handle<reco::TrackCollection> tracksH; | ||
| ev.getByToken(tracksToken_, tracksH); | ||
| const auto& tracks = *tracksH; | ||
|
|
||
| edm::Handle<reco::TrackCollection> tracksMTDH; | ||
| ev.getByToken(tracksMTDToken_, tracksMTDH); | ||
|
|
||
| const auto& btlMatchChi2 = ev.get(btlMatchChi2Token_); | ||
| const auto& btlMatchTimeChi2 = ev.get(btlMatchTimeChi2Token_); | ||
| const auto& etlMatchChi2 = ev.get(etlMatchChi2Token_); | ||
| const auto& etlMatchTimeChi2 = ev.get(etlMatchTimeChi2Token_); | ||
| const auto& pathLength = ev.get(pathLengthToken_); | ||
| const auto& trackAssoc = ev.get(trackAssocToken_); | ||
| const auto& mtdTime = ev.get(mtdTimeToken_); | ||
|
|
||
| std::vector<float> mvaOutRaw; | ||
|
|
||
| //Loop over tracks collection | ||
| for (unsigned int itrack = 0; itrack < tracks.size(); ++itrack) { | ||
| const reco::TrackRef trackref(tracksH, itrack); | ||
| if (trackAssoc[trackref] == -1) | ||
| mvaOutRaw.push_back(-1.); | ||
| else { | ||
| const reco::TrackRef mtdTrackref = reco::TrackRef(tracksMTDH, trackAssoc[trackref]); | ||
| mvaOutRaw.push_back(mva_( | ||
| trackref, mtdTrackref, btlMatchChi2, btlMatchTimeChi2, etlMatchChi2, etlMatchTimeChi2, mtdTime, pathLength)); | ||
| } | ||
| } | ||
| fillValueMap(ev, tracksH, mvaOutRaw, mvaName); | ||
| } | ||
|
|
||
| //define this as a plug-in | ||
| #include <FWCore/Framework/interface/MakerMacros.h> | ||
| DEFINE_FWK_MODULE(MTDTrackQualityMVAProducer); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| from RecoMTD.TimingIDTools.mtdTrackQualityMVAProducer_cfi import * | ||
|
|
||
| mtdTrackQualityMVA = mtdTrackQualityMVAProducer.clone() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic in the ::produce suggests that both should be not empty ==> use
&&.Also, apparently, the conditions should include
&& storeTiming_