Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM: Switch to edm::stream for DQMEDAnalyzer #28813

Merged
merged 5 commits into from
Mar 3, 2020

Commits on Feb 21, 2020

  1. Switch to edm::stream.

    schneiml committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    81d950d View commit details
    Browse the repository at this point in the history
  2. Remove beginJob/endJob in DQMEDAnalyzer.

    Most of them where useless, or only to call DQMStore::save().
    That might be useful, but we really don't like people doing that so I removed them.
    
    In a few cases modules were migrated to DQMOneEDAnalyzer because they had nontrivial logic in the beginJOb/endJob.
    That logic is most likely broken either ways, but like this it at least still compiles.
    schneiml committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    02ff2b8 View commit details
    Browse the repository at this point in the history
  3. Add streamId in DQMEDAnalyzer.

    I assumed the edm::stream instances would have independent module IDs,
    but they don't, so we need to explcitly mix in the stream ID.
    
    For now, DQMEDAnalyzer does not allow changing stream ids, but it would
    probably work fine even if beginStream is called multiple times.
    schneiml committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    6dfd277 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Convert a few modules to edm::one.

    These were showing significant differences when running with multiple streams.
    schneiml committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    81ef76e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Configuration menu
    Copy the full SHA
    ad175ed View commit details
    Browse the repository at this point in the history