[LLVM 9] Fixed build errors #28810

smuzaffar · 2020-01-28T11:32:09Z

PR description:

Build with LLVM 9.0 fails due to these errors. This PR proposes the changes to make llvm 9 happy

PR validation:

locally build with llvm 9.0.1 do not fail any more

cmsbuild · 2020-01-28T11:32:34Z

The code-checks are being triggered in jenkins.

smuzaffar · 2020-01-28T11:33:31Z

Alignment/MillePedeAlignmentAlgorithm/interface/MillePedeFileReader.h

@@ -169,7 +169,7 @@ class MillePedeFileReader {

 const std::array<std::string, 8> coord_str = {{"X", "Y", "Z", "theta_X", "theta_Y", "theta_Z", "extra_DOF", "none"}};
 inline std::ostream& operator<<(std::ostream& os, const AlignPCLThresholds::coordType& c) {
-  if (c >= AlignPCLThresholds::endOfTypes || c < 0)
+  if (c >= AlignPCLThresholds::endOfTypes || c < AlignPCLThresholds::X)


we can drop || c<0 part as it is always false

Alignment/MillePedeAlignmentAlgorithm/interface/MillePedeFileReader.h:172:48: error: result of comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]

In principle the whole if statement seems to be redundant (unless something casts an integer into the enumeration without bounds checking)

cmssw/CondFormats/PCLConfig/interface/AlignPCLThresholds.h

Line 14 in dcdf62c

enum coordType { X, Y, Z, theta_X, theta_Y, theta_Z, extra_DOF, endOfTypes };

smuzaffar · 2020-01-28T11:35:18Z

EgammaAnalysis/ElectronTools/interface/EnergyScaleCorrection_class.h

@@ -192,7 +192,7 @@ class EnergyScaleCorrection_class {
  void ReadSmearingFromFile(TString filename);  ///< File structure: category constTerm alpha;
 public:
  inline void SetSmearingType(fileFormat_t value) {
-    if (value >= 0 && value <= 1) {
+    if (value <= 1) {


value >= 0 is always true as value is of type fileFormat_t enum.

EgammaAnalysis/ElectronTools/interface/EnergyScaleCorrection_class.h:195:15: error: result of comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-unsigned-enum-zero-compare]

smuzaffar · 2020-01-28T11:36:20Z

HLTrigger/JetMET/src/HLTJetSortedVBFFilter.cc

@@ -162,7 +162,7 @@ bool HLTJetSortedVBFFilter<T>::hltFilter(edm::Event& event,
      nJet++;
      //   		cout << "jetPt=" << jet->pt() << "\tjetEta=" << jet->eta() << "\tjetCSV=" << value << endl;
    }
-    if (b1_idx >= sorted.size() || b1_idx < 0)
+    if (b1_idx >= sorted.size())


b1_idx is unsigned int so b1_idx < 0 is always false

HLTrigger/JetMET/src/HLTJetSortedVBFFilter.cc:165:43: error: result of comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-unsigned-zero-compare]

smuzaffar · 2020-01-28T11:37:04Z

RecoEgamma/EgammaTools/src/EnergyScaleCorrection.cc

@@ -171,7 +171,7 @@ void EnergyScaleCorrection::addSmearing(const std::string& category,
 }

 void EnergyScaleCorrection::setSmearingType(FileFormat value) {
-  if (value >= 0 && value <= 1) {
+  if (value <= 1) {


value >= 0 is always true as value is of type FileFormat enum.

RecoEgamma/EgammaTools/src/EnergyScaleCorrection.cc:174:13: error: result of comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-unsigned-enum-zero-compare]

cmsbuild · 2020-01-28T11:37:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28810/13513

This PR adds an extra 32KB to repository

cmsbuild · 2020-01-28T11:37:46Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm
EgammaAnalysis/ElectronTools
HLTrigger/JetMET
RecoEgamma/EgammaTools
RecoTauTag/RecoTau

@perrotta, @Martin-Grunewald, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @fwyzard, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@Sam-Harper, @adewit, @riga, @tlampen, @varuns23, @tocheng, @lgray, @Martin-Grunewald, @sobhatta, @afiqaize, @mschrode, @mmusich, @jainshilpi this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2020-01-28T11:38:49Z

RecoTauTag/RecoTau/plugins/DPFIsolation.cc

@@ -168,8 +168,6 @@ class DPFIsolation : public deep_tau::DeepTauBase {

        if (p.pt() < 0.5)
          continue;
-        if (p.fromPV() < 0)
-          continue;


p.fromPV() returns PVAssoc enum which is always >=0 ( https://cmssdt.cern.ch/lxr/source/DataFormats/PatCandidates/interface/PackedCandidate.h#0703 )

RecoTauTag/RecoTau/plugins/DPFIsolation.cc:171:24: error: result of comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]

unless the check was supposed to be p.fromPV() == 0 (and p.fromPV() <= 1 below) ?

@ocolegrove @MRD2F @mbluj
It appears that a check "p.fromPV() < 0" is redundant.
please double-check that we are not hiding some problem in your original code.

I guess it is fine the remove the p.fromPV() < 0 redundant check.

cmsbuild · 2020-01-28T14:17:51Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5505
Test Parameters:

BUILD_FULL_CMSSW = true
RELEASE_FORMAT = CMSSW_11_1_CLANG_X
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4385/console Started: 2020/01/28 15:19

cmsbuild · 2020-01-28T21:19:36Z

-1

Tested at: dcdf62c

CMSSW: CMSSW_11_1_CLANG_X_2020-01-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5cb1c/4385/summary.html

I found follow errors while testing this PR

Failed tests: HeaderConsistency

cmsbuild · 2020-01-28T21:19:39Z

Comparison job queued.

cmsbuild · 2020-01-29T01:07:48Z

+1
Tested at: dcdf62c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa6cfb/4397/summary.html
CMSSW: CMSSW_11_1_X_2020-01-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-01-29T01:07:51Z

Comparison job queued.

cmsbuild · 2020-01-29T02:44:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa6cfb/4397/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697090
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696743
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

Martin-Grunewald · 2020-01-30T15:44:36Z

+1

slava77 · 2020-01-30T16:27:35Z

+1

for #28810 dcdf62c

mostly technical, as described
also, one somewhat questionable case was confirmed in [LLVM 9] Fixed build errors #28810 (comment)

christopheralanwest · 2020-01-30T16:58:54Z

+1

silviodonato · 2020-01-30T17:36:41Z

merge
@santocch please have a look

santocch · 2020-02-18T19:59:14Z

+1

cmsbuild · 2020-02-18T19:59:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[LLVM 9] Fixed build errors

dcdf62c

cmsbuild added this to the CMSSW_11_1_X milestone Jan 28, 2020

cmsbuild added alca-pending analysis-pending code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 28, 2020

smuzaffar commented Jan 28, 2020

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 28, 2020

smuzaffar commented Jan 28, 2020

View reviewed changes

smuzaffar mentioned this pull request Jan 28, 2020

LLVM to 9.0.1 cms-sw/cmsdist#5505

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Jan 28, 2020

cmsbuild added tests-rejected and removed tests-started labels Jan 28, 2020

cmsbuild added tests-pending tests-started and removed requires-external tests-pending labels Jan 28, 2020

cmsbuild added tests-approved and removed tests-started labels Jan 29, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jan 29, 2020

cmsbuild added hlt-approved and removed hlt-pending labels Jan 30, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 30, 2020

cmsbuild added alca-approved and removed alca-pending labels Jan 30, 2020

cmsbuild added orp-approved and removed orp-pending labels Jan 30, 2020

cmsbuild merged commit dc86c99 into cms-sw:master Jan 30, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Feb 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLVM 9] Fixed build errors #28810

[LLVM 9] Fixed build errors #28810

smuzaffar commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

smuzaffar Jan 28, 2020

makortel Jan 29, 2020 •

edited

Loading

smuzaffar Jan 28, 2020

smuzaffar Jan 28, 2020

smuzaffar Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

smuzaffar Jan 28, 2020 •

edited

Loading

fwyzard Jan 28, 2020

slava77 Jan 29, 2020

mbluj Jan 30, 2020

cmsbuild commented Jan 28, 2020 •

edited

Loading

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

Martin-Grunewald commented Jan 30, 2020

slava77 commented Jan 30, 2020

christopheralanwest commented Jan 30, 2020

silviodonato commented Jan 30, 2020

santocch commented Feb 18, 2020

cmsbuild commented Feb 18, 2020

[LLVM 9] Fixed build errors #28810

[LLVM 9] Fixed build errors #28810

Conversation

smuzaffar commented Jan 28, 2020

PR description:

PR validation:

cmsbuild commented Jan 28, 2020

smuzaffar Jan 28, 2020

Choose a reason for hiding this comment

makortel Jan 29, 2020 • edited Loading

Choose a reason for hiding this comment

smuzaffar Jan 28, 2020

Choose a reason for hiding this comment

smuzaffar Jan 28, 2020

Choose a reason for hiding this comment

smuzaffar Jan 28, 2020

Choose a reason for hiding this comment

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

smuzaffar Jan 28, 2020 • edited Loading

Choose a reason for hiding this comment

fwyzard Jan 28, 2020

Choose a reason for hiding this comment

slava77 Jan 29, 2020

Choose a reason for hiding this comment

mbluj Jan 30, 2020

Choose a reason for hiding this comment

cmsbuild commented Jan 28, 2020 • edited Loading

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

cmsbuild commented Jan 29, 2020

Martin-Grunewald commented Jan 30, 2020

slava77 commented Jan 30, 2020

christopheralanwest commented Jan 30, 2020

silviodonato commented Jan 30, 2020

santocch commented Feb 18, 2020

cmsbuild commented Feb 18, 2020

makortel Jan 29, 2020 •

edited

Loading

smuzaffar Jan 28, 2020 •

edited

Loading

cmsbuild commented Jan 28, 2020 •

edited

Loading