bug-fix for infinite loop in MuonSimClassifier.cc

[Fedespring]

PR description:

Infinite loop happens in the RECOSIM step, because Gen Muons appear as the first GenParticle in the tree: https://its.cern.ch/jira/browse/CMSMUONS-312
Added a break to end the loop (when it happens) still keeping the LogTrace.
This fix the issue.

PR validation:

Validation done using the configuration, LHE and few root files provided by pdmv (can be found in
/afs/cern.ch/user/s/srimanob/public/ForPdmV/McM/PPS-RunIIFall18GS-00004)

Running runTheMatrix.py -l limited -i all
6 5 4 3 2 0 0 0 0 tests passed, 28 0 0 0 0 0 0 0 0 failed

Backporting is needed in 10_2_X

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13503

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13503/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13503/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[srimanob]

@Fedespring
Thanks. Local test seems to run fine in MiniAOD step. Another following issue in NanoAOD is reported in #28803
Somehow rivert can match only a single parton.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13530

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13530/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13530/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13532

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Fedespring for master.

It involves the following packages:

SimMuon/MCTruth

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @folguera, @trocino, @cericeci this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28802/13575

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #28802 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4449/console Started: 2020/01/31 15:31

[cmsbuild]

+1
Tested at: 52c69d7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caf567/4449/summary.html
CMSSW: CMSSW_11_1_X_2020-01-31-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-caf567/4449/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697068
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696721
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[srimanob]

Hi @Fedespring

Do I understand correctly that backport to 10_2 has not happed yet?

I make the backport at
#29065

It is needed for Autumn18 MC (10_2) production.

Thx.

[Fedespring]

Yes correct. Thanks Il Sab 29 Feb 2020, 22:41 Phat Srimanobhas <notifications@github.com> ha scritto:

…

Hi @Fedespring <https://github.com/Fedespring> Do I understand correctly that backport to 10_2 has not happed yet? I make the backport at #29065 <#29065> It is needed for MC production. Thx. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#28802?email_source=notifications&email_token=ACI4KO42AGUVF7LJFPEVOCDRFGAJ7A5CNFSM4KMIBQL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMGZOI#issuecomment-592997561>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACI4KO6VMCC7R5T77DNHPPTRFGAJ7ANCNFSM4KMIBQLQ> .