Bug fix in DaqProvenanceHelper

[wddgit]

PR description:

This fixes the bug reported in issue #28786. I understand
the problem causing the exception and fixed it.

I added a call to setIsProvenanceSetOnRead on the
BranchDescription. This has been needed since
PR #28536 for FedRawDataInputSource to work
properly.

PR validation:

Using the test provided in the issue with the problem
report, I reproduced the exception and verified the
exception does not occur with the fix in place.

I somewhat narrowly focused on the reported exception.
It might be worth it for an expert responsible for
FedRawDataInputSource to verify it is really working.
Maybe the test in the bug report is sufficient, it runs
successfully to completion with the fix.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28791/13472

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Sources

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4351/console Started: 2020/01/24 23:36

[cmsbuild]

+1
Tested at: c898011
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5258d/4351/summary.html
CMSSW: CMSSW_11_1_X_2020-01-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5258d/4351/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697090
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696743
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #28799
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4372/console Started: 2020/01/27 19:35

[cmsbuild]

+1
Tested at: c898011
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67bdb4/4372/summary.html
CMSSW: CMSSW_11_1_X_2020-01-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67bdb4/4372/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697090
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696743
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files