Clean BuildFiles in RecoEgamma and PhysicsTools #28779

guitargeek · 2020-01-22T20:28:06Z

PR description:

To follow the goal of cmssw more modular, I automatically removed all dependencies in the BuildFiles of the RecoEgamma and PhysicsTools subsystems which are not needed.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR:

No backport intended.

cmsbuild · 2020-01-22T20:28:33Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-22T20:42:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28779/13447

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/ONNXRuntime/BuildFile.xml modified in PR(s): Skip building onnx code on PowerPC. The external is not supported #28572

cmsbuild · 2020-01-22T20:43:14Z

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

PhysicsTools/FWLite
PhysicsTools/HepMCCandAlgos
PhysicsTools/JetCharge
PhysicsTools/JetMCAlgos
PhysicsTools/JetMCUtils
PhysicsTools/MXNet
PhysicsTools/ONNXRuntime
PhysicsTools/ParallelAnalysis
PhysicsTools/PatAlgos
PhysicsTools/PatExamples
PhysicsTools/RecoUtils
PhysicsTools/RooStatsCms
PhysicsTools/SelectorUtils
PhysicsTools/TagAndProbe
PhysicsTools/TensorFlow
PhysicsTools/UtilAlgos
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaPhotonAlgos
RecoEgamma/EgammaTools
RecoEgamma/Examples
RecoEgamma/PhotonIdentification

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jainshilpi, @hatakeyamak, @emilbols, @HeinerTholen, @ahinzmann, @lgray, @peruzzim, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @acaudron, @varuns23, @jdolen, @hqucms, @ferencek, @Sam-Harper, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @sobhatta, @afiqaize, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-01-22T21:30:10Z

RecoEgamma/Examples/plugins/BuildFile.xml

 <use   name="SimDataFormats/CrossingFrame"/>
 <use   name="SimDataFormats/GeneratorProducts"/>
 <use   name="SimDataFormats/Track"/>
 <use   name="SimDataFormats/TrackingAnalysis"/>
 <use   name="SimDataFormats/Vertex"/>
+<use   name="classlib"/>


I do not see any classlib/ includes in RecoEgamma.
does this dependence come through some other packages headers?
Usually that dependence should bring in everything else and there is no need to unroll to the full dep list

Good catch, you are right. I was adding it because it didn't compile, and then I added DQMServices/Core because it still didn't compile. Now I understand that only adding the latter is enough, so I will amend the last commit.

cmsbuild · 2020-01-22T22:06:13Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-22T22:06:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-01-22T22:11:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28779/13449

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/ONNXRuntime/BuildFile.xml modified in PR(s): Skip building onnx code on PowerPC. The external is not supported #28572

cmsbuild · 2020-01-22T22:12:21Z

Pull request #28779 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

slava77 · 2020-01-22T22:53:44Z

@cmsbuild please test

cmsbuild · 2020-01-22T22:54:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4325/console Started: 2020/01/22 23:58

cmsbuild · 2020-01-23T00:43:26Z

-1

Tested at: 331a10e

CMSSW: CMSSW_11_1_X_2020-01-22-1400
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c855c4/4325/summary.html

I found follow errors while testing this PR

Failed tests: HeaderConsistency

cmsbuild · 2020-01-23T00:43:28Z

Comparison job queued.

cmsbuild · 2020-01-28T21:40:20Z

Pull request #28779 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

makortel · 2020-01-28T21:40:26Z

@cmsbuild, please test

(indeed core signature is no longer needed)

cmsbuild · 2020-01-28T21:40:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4395/console Started: 2020/01/28 22:43

cmsbuild · 2020-01-28T23:29:58Z

+1
Tested at: f3df3fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c855c4/4395/summary.html
CMSSW: CMSSW_11_1_X_2020-01-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-01-28T23:30:02Z

Comparison job queued.

cmsbuild · 2020-01-29T01:11:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c855c4/4395/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2697090
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696743
DQMHistoTests: Total skipped: 346
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

slava77 · 2020-01-29T16:05:25Z

+1

for #28779 f3df3fa

compared to the previous signoff, earlier edits in DataFormats/CLHEP/BuildFile.xml and DataFormats/PatCandidates/BuildFile.xml were removed as unnecessary

silviodonato · 2020-01-30T10:00:49Z

Kind reminder @santocch

silviodonato · 2020-01-30T17:31:35Z

merge

santocch · 2020-02-18T19:58:48Z

+1

cmsbuild · 2020-02-18T19:59:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

removed unneeded build dependencies in PhysicsTools

b1e95f8

cmsbuild added this to the CMSSW_11_1_X milestone Jan 22, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 22, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 22, 2020

slava77 reviewed Jan 22, 2020

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 22, 2020

remove unused dependencies from RecoEgamma

331a10e

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 22, 2020

cmsbuild added tests-started and removed tests-pending labels Jan 22, 2020

cmsbuild added the code-checks-approved label Jan 28, 2020

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2020

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jan 29, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 29, 2020

cmsbuild added orp-approved and removed orp-pending labels Jan 30, 2020

cmsbuild merged commit 71c1f13 into cms-sw:master Jan 30, 2020

guitargeek deleted the clean_buildfiles_PhysicsTools_RecoEgamma branch January 30, 2020 21:16

guitargeek mentioned this pull request Jan 31, 2020

Clean BuildFiles in RecoMuon and RecoParticleFlow #28835

Merged

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Feb 18, 2020

slava77 mentioned this pull request Jun 17, 2020

[10_6_X] ONNXRuntime-based implementation of DeepJet, DeepAK8 and DeepDoubleX #30123

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean BuildFiles in RecoEgamma and PhysicsTools #28779

Clean BuildFiles in RecoEgamma and PhysicsTools #28779

guitargeek commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

slava77 Jan 22, 2020

guitargeek Jan 22, 2020 •

edited

Loading

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

slava77 commented Jan 22, 2020

cmsbuild commented Jan 22, 2020 •

edited

Loading

cmsbuild commented Jan 23, 2020

cmsbuild commented Jan 23, 2020

cmsbuild commented Jan 28, 2020

makortel commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 •

edited

Loading

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 29, 2020

slava77 commented Jan 29, 2020

silviodonato commented Jan 30, 2020

silviodonato commented Jan 30, 2020

santocch commented Feb 18, 2020

cmsbuild commented Feb 18, 2020

Clean BuildFiles in RecoEgamma and PhysicsTools #28779

Clean BuildFiles in RecoEgamma and PhysicsTools #28779

Conversation

guitargeek commented Jan 22, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

slava77 Jan 22, 2020

Choose a reason for hiding this comment

guitargeek Jan 22, 2020 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

cmsbuild commented Jan 22, 2020

slava77 commented Jan 22, 2020

cmsbuild commented Jan 22, 2020 • edited Loading

cmsbuild commented Jan 23, 2020

cmsbuild commented Jan 23, 2020

cmsbuild commented Jan 28, 2020

makortel commented Jan 28, 2020

cmsbuild commented Jan 28, 2020 • edited Loading

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 28, 2020

cmsbuild commented Jan 29, 2020

slava77 commented Jan 29, 2020

silviodonato commented Jan 30, 2020

silviodonato commented Jan 30, 2020

santocch commented Feb 18, 2020

cmsbuild commented Feb 18, 2020

guitargeek Jan 22, 2020 •

edited

Loading

cmsbuild commented Jan 22, 2020 •

edited

Loading

cmsbuild commented Jan 28, 2020 •

edited

Loading