-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyReleaseValidation production-like workflow for Run3 (2021) #28773
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28773/13427
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/PyReleaseValidation @chayanit, @cmsbuild, @pgunnell, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test testing only that nothing old is broken, the addition needs to be tested with |
@davidlange6 @slava77 FYI |
The tests are being triggered in jenkins. |
-1 Tested at: c67d7be CMSSW: CMSSW_11_1_X_2020-01-21-1100 I found follow errors while testing this PR Failed tests: Python3
I found errors: *** Error compiling 'src/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py'... |
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
Outdated
Show resolved
Hide resolved
@fabiocos I think the test failure is because of incorrect indentation, but see my review comment #28773 (comment) for a way to simplify the PR |
c67d7be
to
49ad23e
Compare
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@fabiocos , I have no comments about the code. For my knowledge, what difference is between prod-like and baseline workflows in general? |
@chayanit the main difference is the absence of DQM, and the output tiers are those used in production. For performance evaluation this may make a difference |
+1 @fabiocos thanks for your prompt response. |
@fabiocos can you update the PR description to indicate the new workflow is now 11634.21 rather than 11634.22? |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@kpedro88 I have updated the description to leave a clean reference |
+1 |
PR description:
This PR proposes a special set of Run3 (2021) workflows in a "production-like" setup, mimicking what already available for Phase2 by @kpedro88 . The purpose is to provide a tool for performance evaluation ready out-of-the-box, and it is not added to the standard set of workflows to avoid inflating it further for such a specific use case (so
--what upgrade
option needs to be invoked).PR validation:
The added configuration cannot be tested directly by the bot. Here is the output: