-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timing propagation in HGCAL RECO #28740
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28740/13368
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The tests are being triggered in jenkins. |
Concerning this, I run it few times at 0PU, and find variations in both directions (+ and - few%) |
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
I've made some timing measurement, not with a PU sample but with wf 21234 (TTbar_14TeV with geometry 2026D44). Looking at the HGCal related modules, I confirm what was suggested by the comment of @amartelli, that is there is no significant cpu time increase due to the additional code:
for an overall time of
(numbers roughly compatible within the precision of the method) |
+1
|
+upgrade |
@Dr15Jones,@smuzaffar,@makortel : is this PR ok for "core"? Please sign, or comment in case you have remarks. |
+1 for |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR
Introduces an error on the time for recHits (currently only the time value is available)
The time and error is propagated to layer clusters, computed as weighted mean of the input recHits
Time and error are propagated to tracksters, computed as weighted mean of the input layerClusters
A validation of the performance was presented at the HGCAL DPG
https://indico.cern.ch/event/866332/contributions/3650459/attachments/1952623/3242126/HGCALtiming_updateNov2019_amartell.pdf
@felicepantaleo @rovere @Shameena01 for reference