Define new CLCT digi format for Run-3

[dildick]

PR description:

During Run-3 the CSC DPG group is planning to run the CSC trigger with new CLCT patterns based on a 12-bit comparator code. These new CLCTs will be of type CSCCLCTRun3Digi to differentiate with the legacy CSCCLCTDigi used in Run-1 and Run-2. An introduction to the new CLCT patterns can be found here: https://indico.cern.ch/event/778315/contributions/3238278/subcontributions/268636/attachments/1770627/2876988/181213-CCStatus_WNASH.pdf. A related PR is #28600.

PR validation:

The code compiles. CSCCLCTRun3Digis are not yet produced in CMSSW. This will be done in a future PR. There should be no change in any standard sequence.

if this PR is a backport please specify the original PR:

N/A

@ptcox @tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28604/13117

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3927/console Started: 2019/12/11 16:32

[cmsbuild]

+1
Tested at: 4deb751
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fb2ce/3927/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fb2ce/3927/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2800084
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2799742
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[dildick]

@civanch Could you wait with signing off for now?

[fabiocos]

@dildick are you expect further development or validation?

[fabiocos]

hold

pending a possible alternative proposal by @dildick

[cmsbuild]

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[silviodonato]

@dildick shall we continue to wait for an update of this PR?

[dildick]

Hi Silvio, I'm working on an alternative proposal where I expand the CLCT data format for Run-3. I plan to present it soon in a CSC DPG meeting. So I suppose we can close this for now.

[silviodonato]

Ok, let's close this PR. Let me know in case you want to open it again.