Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Service callbacks for Run and Lumi writing #28562

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The new signals are used to announce when starting and ending of the OutputModule write phases occur for Runs and LuminosityBlocks.

PR validation:

All framework unit tests pass.

The new signals are used to announce when starting and ending of the OutputModule write phases occur for Runs and LuminosityBlocks.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28562/13049

  • This PR adds an extra 80KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration
FWCore/ServiceRegistry
FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit, @fwyzard this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3831/console Started: 2019/12/05 18:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

-1

Tested at: 9352d6c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4be765/3831/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Comparison job queued.

@Dr15Jones
Copy link
Contributor Author

+1
the unit test failure happens also in the IB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4be765/3831/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799741
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 6, 2019

please test

the failure is unrelated to this PR, a fix has just been merged

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3846/console Started: 2019/12/06 16:29

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2019

-1

Tested at: 9352d6c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4be765/3846/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4be765/3846/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799741
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Dr15Jones
Copy link
Contributor Author

@fabiocos the unit test fix evidently was not picked up.

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2019

+1

the failure is unrelated to this PR

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2019

merge

@cmsbuild cmsbuild merged commit 5ce7237 into cms-sw:master Dec 7, 2019
@Dr15Jones Dr15Jones deleted the newWriteSignals branch December 10, 2019 20:37
@schneiml schneiml mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants