-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled PCA inputs for deepTau v2 (backport to 10_2_X) #27879
Disabled PCA inputs for deepTau v2 (backport to 10_2_X) #27879
Conversation
A new Pull Request was created by @swozniewski for CMSSW_10_2_X. It involves the following packages: RecoTauTag/RecoTau @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Disabling of usage of dxy_PCA coordinates controlled with a parameter, and new version with the disabling added to the tauID python tool as in PR to master, but deepTauID is not included to any official workflow (as in production 10_2_X releases). |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
backport of #27878 |
please test workflow 136.7722,136.7952,136.8521,1325.6,1325.7,1325.8,1329.1 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
PR description:
Problems have been detected with dxy_PCA input variables to DeepTauID which are inconsistent between data and MC. This PR sets input values to 0 and disables the variables this way.
Issue and fix were discussed in https://indico.cern.ch/event/842796/contributions/3541592/attachments/1897386/3130770/2019-08-26_DeepTau_ID_2017v2_DY_MC_vs_Embedded_and_bug_in_definition_of_PCA_variables.pdf (see slide 7 in particular)
Backport to 10_2_X for legacy analyses intended.
PR validation:
compiles
if this PR is a backport please specify the original PR:
#27878