backporting generator filter modifications to CMSSW_7_1_X

[danielwinterbottom]

PR description:

Backport of #27791 modifying EmbeddingHepMCFilter:

• Setting the boson PDGID under option so that the filter can be used for Higgs events
• Adding booleans to make sure the correct tau decay types are identified in cases where there are additional FSR photons
  These modifications are needed so that we can use this filter in a MC request for 2016, 2017, and 2018 MC samples and therefore need this to be backported to CMSSW_7_1_X, CMSSW_9_3_X, and CMSSW_10_2_X.
  The EmbeddingHepMCFilter does not currently exist on 7_1_X so this PR adds the latest version of the filter from the master branch
  The filter reduces the required statistics for our samples by a factor of 4 - without this filter the size of the sample required would be unfeasible to produce

PR validation:

• Checked that the modifications compile in CMSSW_7_1_32_patch1 and CMSSW_7_1_X_2019-08-18-0000
• Checked by generating GEN-SIM events in CMSSW_7_1_32_patch1 and CMSSW_7_1_X_2019-08-18-0000 that generator runs and that filter works correctly

if this PR is a backport please specify the original PR:

#27791

[cmsbuild]

A new Pull Request was created by @danielwinterbottom (Daniel Winterbottom) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/Core
TauAnalysis/MCEmbeddingTools

@efeyazgan, @civanch, @mdhildreth, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy, @santocch can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[qliphy]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2173/console Started: 2019/08/25 16:45

[cmsbuild]

+1
Tested at: de45778
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0ad9/2173/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e0ad9/2173/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 682535
• DQMHistoTests: Total failures: 3316
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 678845
• DQMHistoTests: Total skipped: 374
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -10 KiB( 10 files compared)
• Checked 44 log files, 4 edm output root files, 11 DQM output files

[qliphy]

+1

[civanch]

+1

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[danielwinterbottom]

Hello, I am wondering how I should raise the backport request in the next release meeting - is this done by filling in the form linked on the agenda for the meeting https://indico.cern.ch/event/842842/ ?

[fabiocos]

@danielwinterbottom this request will appear in the list for 7_1_X, you may add an note using the form in case. For which production is this backport needed?

[danielwinterbottom]

Sorry I was away for a couple of days and missed your message. I also didn't add a note for the Tuesday meeting for the same reason. We currently need to use these filters to produce 2016 legacy, 2017, and 2018 MC samples needed for 3 Higgs->tautau CP analyses (the equivalent PRs to 9_3_X and 10_2_X are here #27864 #27863). This is my first time requesting backports so I am not completely familiar with the procedure but am I right in thinking that once these are approved we will need to also wait for them to be included in a working version of the corresponding CMSSW releases? - if so how often do new versions get released (this would be very useful to know so that we can get an idea of the timeframe for making the MC requests)?

[fabiocos]

@danielwinterbottom normally before integrating a backport of a code we do want to have it into the master (now 11_0_X) branch and have some test of it there.

[danielwinterbottom]

@fabiocos the code is already in the 11_0_X branch. I just did some tests using CMSSW_11_0_0_pre7: I checked the code built and then ran a few MC events with the filter applied running this config https://github.com/danielwinterbottom/cmssw/blob/from-CMSSW_11_0_0_pre7/ggH_2018.py. You can see from the output (https://github.com/danielwinterbottom/cmssw/blob/from-CMSSW_11_0_0_pre7/test.out) that the filter is filtering the events as expected (with efficiency ~ 1/4 the same as we observed in the private MC samples we ran previously). Are there any other specific tests that you need me to run before the backport can be integrated?

[fabiocos]

+1