-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ad-hoc fix of Relvals TaskName more than 50 characters #27779
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27779/11464
|
A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @prebello, @chayanit, @zhenhu, @kpedro88, @pgunnell can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27779/11519
|
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This appears to have a python 3 problem:
|
fixed with #27859 |
PR description:
This PR aims to fix the restriction of TaskName added by WMCore in (dmwm/WMCore@e15eee0) for RelVals injection. Mainly due to GEN fragment convention. The solution is to check if the TaskName is greater than 50 characters and
PR validation:
Local test is done with one of the longest TaskName "DisplacedSUSY_stopToBottom_M_300_1000mm_TuneCUETP8M1_13TeV_pythia8_2018_GenSimFull"
runTheMatrix.py --what upgrade -l 10884.0
https://cmsweb.cern.ch/reqmgr2/fetch?rid=request-chayanit_RVCMSSW_11_0_0_pre5DisplacedSUSY_stopToBottom_M_300_1000mm_13_190820_164120_6223
The TaskName and InputTask is reduced to GenSimFull for this case