Bug fix for 2016-2017 HBHE negative energy filter [10_6_X]

[christopheralanwest]

PR description:

This is a backport of PR #27733

GT diffs:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_v18/106X_dataRun2_v20
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_v17/106X_dataRun2_relval_v19

PR validation:

See PR #27733 description for details. In addition, runTheMatrix.py -l limited -i all --ibeos was run as a technical test.

if this PR is a backport please specify the original PR:

This is a backport of PR #27733

[christopheralanwest]

backport #27733

[cmsbuild]

A new Pull Request was created by @christopheralanwest for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Bug fix for 2016-2017 HBHE negative energy filter #27733

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1923/console Started: 2019/08/08 22:58

[cmsbuild]

+1
Tested at: fc56673
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e63b6/1923/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e63b6/1923/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4169 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211049
• DQMHistoTests: Total failures: 329
• DQMHistoTests: Total nulls: 9
• DQMHistoTests: Total successes: 3210377
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.059 KiB( 32 files compared)
• DQMHistoSizes: changed ( 136.788 ): 0.086 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.85 ): -0.027 KiB JetMET/SUSYDQM
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[christopheralanwest]

+1

• payload included in this autoCond update validated with local tests
• expected differences seen in 2016 and 2017 workflows. There is an additional change in 2018 workflows relative to the PR to master. During the 2018 preparation, an IOV append was performed on the tag SiPixelLorentzAngle_forWidth_v2_offline with label forWidth. The append was performed at 2019-07-25 12:47:46 whereas the snapshot time of the 106X_dataRun2_v18 GT is 2019-07-24 22:36:38. As a result, this IOV append is not considered for the 106X_dataRun2_v18 GT but is for the 106X_dataRun2_v20 GT. In any case, the origin of the reco difference in 2018 data workflows is understood.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[christopheralanwest]

@fabiocos @kpedro88 What are the plans for merging this PR? Since the global tags in this PR are already in use, PR #27698 and the upcoming backport of #27644 should both include the conditions updates here. I would really prefer if AlCa does not have to introduce incorrect global tags that revert bug fixes for PR testing.

[kpedro88]

+1