Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store DeepTauID in NanoAOD (backport for UL) #27227

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Jun 17, 2019

PR description:

This PR is to store novel DeepTauIDs computed at MiniAOD step to NanoAOD tables.
It can be seen as an follow up action announced here: #27146 (comment)

Expected changes: six new variables are added to tau table in NanoAOD - three raw values (float numbers) of tau discriminants against jets, electrons and muons misidentified as taus, and three integer numbers encoding corresponding WPs.
NanoAOD for old eras should not be modified and should work on top of corresponding MiniAOD inputs not containing DeepTauID variables.

This PR is backport of #27226 to 10_6_X for UL.

PR validation:

NanoAOD workflows were tested.

if this PR is a backport please specify the original PR:

Backport of #27226.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@peruzzim
Copy link
Contributor

please test workflow 1325.6,1325.7,1325.8,1329.1,136.7722,136.7952,136.8521

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1058/console Started: 2019/06/19 16:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8f7f0/1058/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 31 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3208236
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3207900
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6.012 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 6.012 KiB Physics/NanoAODDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@peruzzim
Copy link
Contributor

+xpog

as in #27226 (comment)

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jul 2, 2019

+1

as agreed with XPOG and PPD

@cmsbuild cmsbuild merged commit e39a7af into cms-sw:CMSSW_10_6_X Jul 2, 2019
@mbluj mbluj deleted the CMSSW_10_6_X_tau-pog_DeepTau2017v2-nano branch October 10, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants