Fix python3 interface problem in RecoTauTag/RecoTau

[fabiocos]

PR description:

In python3, dict no longer has an iteritems method.

PR validation:

Identical backport from 11_0_X

if this PR is a backport please specify the original PR: #27189

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_6_X.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix python3 interface problem in RecoTauTag/RecoTau #27189

[fabiocos]

@Dr15Jones if we want to have in future 10_6_X python3 compatible better to backport your fix

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/954/console Started: 2019/06/14 13:11

[cmsbuild]

+1
Tested at: 5a2a7c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8adce/954/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Update global tags to include new EGamma regression [10_6_X] #27205 @christopheralanwest: Update global tags to include new EGamma regression [10_6_X]
• add pileup scenario for 2018 ultra legacy (10_6 backport) #27200 @plujan: add pileup scenario for 2018 ultra legacy (10_6 backport)
• Update of DeepTauID to ver. 2017v2 (backport for UL) #27146 @cms-tau-pog: Update of DeepTauID to ver. 2017v2 (backport for UL)
• Adapting EGRegression Modifiers to 106X and adding V3 modifier: 106X #27203 @Sam-Harper: Adapting EGRegression Modifiers to 106X and adding V3 modifier: 106X

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8adce/954/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8adce/954/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8adce/954/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8889 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208236
• DQMHistoTests: Total failures: 1843
• DQMHistoTests: Total nulls: 6
• DQMHistoTests: Total successes: 3206053
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.024 KiB( 32 files compared)
• DQMHistoSizes: changed ( 136.85 ): 0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.788 ): 0.008 KiB JetMET/SUSYDQM
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/962/console Started: 2019/06/14 21:55

[cmsbuild]

+1
Tested at: 5a2a7c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8adce/962/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8adce/962/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208236
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207901
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #27189

[fabiocos]

+1