renaming 2019 scenario to 2021 ...

[boudoul]

PR description:

As decided by PPD (@franzoni ,@srimanob ) the 2019 scenario should be renamed to 2021 - This PR is adressing this - There were quite a lot of changes. I hope I didnt miss any.
Of course various reviewers can comment if for some special cases they want to keep the name of '2019' .

PR validation:

It is compiling (checkdeps is bringing a lot of packages to compile) -
I ran one of the ex-2019, now 2021, WF : TTBar number 11624.0 - Was running smoothly.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26535/9416

• This PR adds an extra 212KB to repository

[cmsbuild]

A new Pull Request was created by @boudoul (boudoul) for master.

It involves the following packages:

CalibCalorimetry/CaloTPG
Calibration/HcalCalibAlgos
Calibration/IsolatedParticles
Configuration/AlCa
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
DetectorDescription/DDCMS
Fireworks/Geometry
Geometry/CMSCommonData
Geometry/DTGeometryBuilder
Geometry/ForwardCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData
Geometry/MuonSimData
Geometry/TrackerNumberingBuilder
L1Trigger/TrackTrigger
RecoMuon/MuonIdentification
RecoParticleFlow/PFClusterProducer
SimMuon/RPCDigitizer

@perrotta, @cmsbuild, @prebello, @Dr15Jones, @alja, @cvuosalo, @civanch, @tlampen, @christopheralanwest, @ianna, @mdhildreth, @pgunnell, @rekovic, @franzoni, @tocheng, @zhenhu, @slava77, @pohsun, @fabiocos, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @abbiendi, @sviret, @echapon, @mmusich, @seemasharmafnal, @venturia, @mmarionncern, @calderona, @vargasa, @jhgoh, @lgray, @HuguesBrun, @drkovalskyi, @ptcox, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @hatakeyamak, @ebrondol, @dgulhan, @Martin-Grunewald, @battibass, @alja, @bachtis, @cbernet, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

@boudoul does this conflict with #26463 or supersede it?

[boudoul]

ah good point - Actually I would be happy that #26463 goes first (because it is not adressing exactly the same topic so better to factorize into 2 PRs ) . So when #26463 is merged I will (likely have to ) rebase this one, but that's fine (and it presumably doesn't prevent to start the review of this one, given the number of signatures.... )

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34347/console Started: 2019/04/25 18:09

[kpedro88]

@boudoul while we are considering this topic:
currently we only have one somewhat generic top-level Run3 Era: https://github.com/cms-sw/cmssw/blob/master/Configuration/Eras/python/Era_Run3_cff.py

should we rename this as Run3_2021, and then plan for later introduction of Run3_2022 and Run3_2023 for the subsequent years, if necessary? (Hopefully we will have less churn than we did in Run2...)

[cmsbuild]

+1
Tested at: 5647730
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26535/34347/summary.html

[cmsbuild]

Comparison job queued.

[slava77]

+1

for #26535 a87a020

• changes since the last reco signoff for renaming 2019 scenario to 2021 ...  #26535 75bc576 were in packages outside of the reco category
• jenkins tests pass renaming 2019 scenario to 2021 ...  #26535 (comment)

[tocheng]

+1

[fabiocos]

+operations

[fabiocos]

@kpedro88 @prebello @zhenhu unless you have objections I will move forward with the integration at next IB

[kpedro88]

+upgrade

[prebello]

+1

no objections

[fabiocos]

+1

[fabiocos]

merge

@rekovic @civanch please have a look, it seems straightforward

[mmusich]

@fabiocos, the workflows I've introduced in #26510 are going to fail, as now the autoCond key phase1_2019_realistic doesn't exist anymore...

[fabiocos]

@mmusich right, but your new PR should fix this, am I correct?

[mmusich]

@mmusich right, but your new PR should fix this, am I correct?

Yes, indeed that should be the case.