Added missing skipEvents to LHESource

[Dr15Jones]

PR description:

When the LHESource gained a fillDescriptions validator, that function did not include 'skipEvents' as an allowed parameter.

PR validation:

The code was tested by running a configuration which was previously failing do to the validation problem. After the code change, the configuration runs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26334/9046

• This PR adds an extra 16KB to repository

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33928/console Started: 2019/04/03 14:59

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeneratorInterface/LHEInterface

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: fbe892c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26334/33928/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26334/33928/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3139747
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3139549
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@efeyazgan @qliphy @alberto-sanchez this is the fix addressing the problem find in production, and which would benefit from the addition of a test using and external lhe file as input, could you please have a look at it?

[alberto-sanchez]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[prebello]

@Dr15Jones could you please take a look in https://its.cern.ch/jira/browse/CMSCOMPPR-5297? PdmV would like an update about the issue. Thank you for your help.

[fabiocos]

@prebello not sure what is the issue: the fix has been merged and will be part of 10_6_0_pre4...

[prebello]

@fabiocos AFAIK the L3 manager has implemented by hand (ad hoc) and resubmit the relval.
The rsb has failed again with the same error.
Therefore I was wondering if this would be a fix that would work "ad hoc" or only after merging in the pre4.

[Dr15Jones]

@prebello in this context what would 'ad hoc' mean? Does McM have the ability to use code that is from the user and not in a release?

[prebello]

@prebello in this context what would 'ad hoc' mean? Does McM have the ability to use code that is from the user and not in a release?

sorry.. I have meant "by hand". for relvals we don't use McM but runThematrix. We usually hack the source code in Configuration/PyReleaseValidation/python that works.

[boudoul]

Hello @prebello - No you cannot have the ability to produce centrally events with runthematrix (or McM it's the same) with a modified cmssw (thankfully! Otherwise all the work you are doing for the release validation for production would be pointless...) .
When you are modifying PyReleaseValidation , it is just the python used to prepare the submission, not an actual code from cmssw.
You already met the same situation with the Bparking ... : #26154 (comment) - Hope this clarifies - Otherwise I'm sure that @franzoni or @srimanob can give you more details. Thanks.

[prebello]

@boudoul is perfectly clear. never mind. Thank you.

[srimanob]

@prebello
One option: if you would like to implement a new relval workflows wihtout waiting new (pre-)release to be available, i.e. pLHE in this case, you can also place the PR now, then do PR test on new additional workflow (see what we do for bParking). That should pick the last code in IB. No need to wait for new release, then add PR again.

If updates is not merged yet, you can use option "with". Not the case of skipEvents as it is merged.