-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a tool to do a bin by bin DQM root file comparison #26283
Added a tool to do a bin by bin DQM root file comparison #26283
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26283/8967
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @andrius-k (Andrius) for master. It involves the following packages: DQMServices/FileIO @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26283/9353
|
Pull request #26283 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
unhold following the discussion at the Core Software meeting https://indico.cern.ch/event/817694/contributions/3413621/attachments/1836773/3009721/go |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@andrius-k @schneiml @fioriNTU a first observation: the differences in the DQM TimerService are not filtered out (as it is done for instance in the RelMon report by the cms-bot). Even on a null comparison as this one this is going to create artificial differences... |
+1 |
PR description:
This PR adds a tool to perform a thorough bin by bin comparison of DQM root files. The main intention is to use this tool during the comparison stage of DQM pull request tests.
PR validation:
The tool does not run as part of CMSSW but rather as a standalone tool, so only local testing of the logic of the tool was made.