-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move lowPtGsfElectronSequence back to highlevelreco (105X) #25773
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25773/8191
|
A new Pull Request was created by @bainbrid for master. It involves the following packages: Configuration/StandardSequences @perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+operations the update of the StandardSequences appears coherent with the purpose of the PR |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR has been made in response to this request.
While Slava suggests to remove the dependence on
rho
and use insteadnPV
or similar, we note that the BDT models used by theLowPtGsfElectronSeedProducer
userho
as an input variable. So removing this dependence would mean a retraining is mandatory. Given the very tight timescales, it is very unlikely that we will be able to retrain the models in time and we expect to rely on the existing models already merged into cms-data. It may be possible for the 10_5_X cycle, but almost certainly not the 10_2_X cycle, which need for data processing ~now.@perrotta @slava77 @mverzett @nancymarinelli