Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop L1 from FastSim premixing stage1 #25697

Closed

Conversation

makortel
Copy link
Contributor

To suppress warning messages as requested in
https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3507/1/1.html

Partial back-port of the first commit of #24184 (limiting to L1, anything beyond would require full backport of #24184).

Tested in CMSSW_10_2_9, no changes expected.

To suppress warning messages. Partial back-port of
de7ed76.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_10_2_X.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test workflow 250202.1,250202.171,250402.1,20234.99,250402.171

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32684/console Started: 2019/01/18 00:01

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25697/32684/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25697/20234.99_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17PU_GenSimHLBeamSpotFull14+SingleNuE10_cf_2023D17PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2023D17PU+RecoFullGlobalPUPRMX_2023D17PU+HARVESTFullGlobalPU_2023D17PU
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25697/250202.1_TTbar_13+TTbar_13+PREMIXUP15_PU25+DIGIPRMXLOCALUP15_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25697/250402.171_TTbar_13+FS_PREMIXUP17_PU50+FS_TTbar_13_PRMXLOCALUP17_PU50+HARVESTUP17FS

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007209
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@srimanob
Copy link
Contributor

@makortel Thanks.
I believe @ssekmen includes in the PR already, #25683 already.

@makortel
Copy link
Contributor Author

@srimanob Well, yes, as @ssekmen's PR is in master branch (which has dropped L1 from premix stage1 for all workflows in #24184). So this PR is orthogonal to #25683.

And now I notice that this PR is incomplete (it still includes L1 in 2017 FastSim premix stage1), I'll fix shortly.

@makortel
Copy link
Contributor Author

Actually, closer inspection reveals that removing L1 from FastSim premix stage1 is not that simple (and my earlier testing was insufficient), so I'll close this PR.

@makortel makortel closed this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants