Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore PA skims, update HI 2018 data test workflows, backport to 103X #25095

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Nov 1, 2018

Following the merge of #24927 the test workflow 140.54 is failing because it is using the PA skims, that were removed. This was unfortunately missed during the scrutiny of the PR. Although the test is technical, and most likely these skims will not be reused in any close future, this PR restores them so as to minimize changes to tests and keep PA skims around for memory.

In order to avoid interferences with the new PbPb skims, the names of modules and paths are all updated adding the PA label. With this update wf 140.54 runs again.

With the occasion, the new skims are added to the 2018 HI data test workflows 140.56 and 140.57, as well as the ALCA step (as in the PPRECO tests on MC).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_3_X.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/Skimming
Configuration/StandardSequences

@cmsbuild, @prebello, @zhenhu, @kpedro88, @pgunnell, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2018

backport #25075

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 1, 2018

please test workflow 140.54,140.56,140.57

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31433/console Started: 2018/11/01 23:00

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25095/31433/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25095/140.54_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25095/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25095/140.57_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162900
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 2, 2018

+operations

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 2, 2018

+upgrade

@zhenhu
Copy link
Contributor

zhenhu commented Nov 2, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 2, 2018

+1

@cmsbuild cmsbuild merged commit 1ee5b9d into cms-sw:CMSSW_10_3_X Nov 2, 2018
@fabiocos fabiocos deleted the restorePAskims103X branch November 19, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants