-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw data remapper #24891
Raw data remapper #24891
Conversation
A new Pull Request was created by @icali (Ivan Amos Cali) for CMSSW_10_3_X. It involves the following packages: EventFilter/RawDataCollector @mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test not really testing much |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
I think only the file 'EventFilter/RawDataCollector/src/RawDataMapperByLabel.cc' should be part of this commit. The others contain only changes to whitespace (and wrong indentation.) |
@mommsen it looks identical to the master PR to me. Perhaps the master PR could have been cleaned up more, but it is already merged. |
@kpedro88, okay, I've missed it in the master PR. Not nice, but it's like that then. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
backport of #24819 |
+1 |
backport to 10_3_X of #24819