-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tested new configuration that works for HI runs #24572
Conversation
A new Pull Request was created by @dinardo (Mauro) for CMSSW_10_2_X. It involves the following packages: DQM/Integration @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test not testing really much... |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@dinardo @andrius-k sorry, is this updated supposed to be valid only for HI? |
No no. It's valid for any kind of run. |
@dinardo right, but some settings were moved before the checks, I was wondering about that |
+1 |
Hi, Is this going to go to the master branch or I need to push a new PR specifically for the master branch? Cheers,
|
@dinardo my bad, I overlooked the fact that this is not a backport. Please do asap a master version corresponding to this code |
Hi, which CMSSW verison shall I use to push the changed into the master?
|
@dinardo you need to be based on 10_3_X, to which master points |
OK, done in CMSSW_10_3_X as you suggested:
|
Tested new configuration that works for HI runs
Tested new configuration that works for HI runs
Tested new configuration that works for HI runs
Tested new configuration that works for HI runs
Tested new configuration that works for HI runs
Tested new configuration that works for HI runs
I updated the tracking configuration as in here:
http://cmslxr.fnal.gov/source/RecoVertex/PrimaryVertexProducer/python/OfflinePrimaryVertices_cfi.py
Now the application is able to read and process HI data.