Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[94X][Backport] DeepAK8 tagger integration #24506

Merged
merged 33 commits into from
Oct 3, 2018
Merged

[94X][Backport] DeepAK8 tagger integration #24506

merged 33 commits into from
Oct 3, 2018

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Sep 11, 2018

Backport of #23768.
Needs external from cms-sw/cmsdist#4327.
The tagger is disabled in the MiniAOD sequence by default to preserve the event content.

hqucms added 30 commits September 11, 2018 06:38
@hqucms
Add MXNet predictor based on the C API.
423c743
@hqucms
DataFormats change for DeepAK8.
8ec435a
@hqucms
Add DeepAK8 tagger.
099d92a 
 - Both the nominal and the decorrelated versions are included, as well
as a few meta taggers (aggregating the scores).
 - Currently it supports only updating a jet collection. The
implementation to run on RECO exists but not tested.
@hqucms
Apply code-checks.
d4c3946
@hqucms
Fix dependency of meta taggers.
0b8ecd5
@hqucms
Fix misuse of edm::Ptr and some clean-ups.
088180b
@hqucms
Override clearDaughters in pat::Jet to reset the daughter cache too.
d5565bc
@hqucms
Some improvements and clean-ups.
5e2177c
@hqucms
Add a test unit for MXNetPredictor.
8252d8e
@hqucms
Fix DeepBoostedJetTagInfoProducer.
3e761fa
@hqucms
Need to sort subjets by pt.
76affa2
@hqucms
Thread-safety and better logging in MXNetPredictor.
0f4acf5
@hqucms
Switch to MXNet C++ API.
f83b467
@hqucms
Protect executor creatation with a mutex in MXNetCppPredictor.
27750ca
@hqucms
Refactor MXNetCppPredictor.
9f5ca88 
Re-bind executor every time for thread-safety.
@hqucms
Remove MXNet C API.
31abb04
@hqucms
Move non-TF code in RecoBTag/TensorFlow to RecoBTag/FeatureTools
f787fed
@hqucms
Code style changes.
bea3ca9
@hqucms
Fix BuildFile.
03dd2cd
@hqucms
Modify MXNet source to avoid rebinding.
8c92f99
@hqucms
Fix BuildFile.
4366f24
@hqucms
Improve the checks when setting up pfDeepBoostedJetTagInfos.
753622e
@hqucms
Update DeepBoostedJet meta-taggers.
2abac15
@hqucms
Rename MXNet Predictor.
11b373f
@hqucms
Style and performance improvements.
7a0e4dc
@hqucms
Mark DeepBoostedJetTagInfo as transient.
9491236
@hqucms
Reorganize TagInfo producers and JetTags producers.
788e161
@hqucms
A few fixes.
57a025f
@hqucms
Improve the setup of DeepBoostedJetTagInfos.
5821e60
@hqucms
Fix applyDeepBtagging_cff to disable deepBTags by default.
dc22ece
@cmsbuild
Copy link
Contributor

Pull request #24506 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2018

@cmsbuild please test with cms-sw/cmsdist#4327

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 17, 2018 •
edited
Loading

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4327
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30467/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30578/console

@cmsbuild
Copy link
Contributor

+1
Tested at: cdd89f8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24506/30467/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24506/30467/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 118
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721213
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2018

+1

for #24506 cdd89f8

  • backport of DeepAK8 tagger integration #23768 is correct in the context of 94X:
    • all relevant code is ported
    • the configuration parts are set to disable deepAK8 in the standard sequences
  • jenkins tests pass and comparisons with the baseline show no differences

@cmsbuild
Copy link
Contributor

+1
Tested at: cdd89f8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24506/30578/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24506/30578/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721221
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor

fabiocos commented Oct 3, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Oct 3, 2018

merge

@cmsbuild cmsbuild merged commit 675b4b2 into cms-sw:CMSSW_9_4_X Oct 3, 2018
@hqucms hqucms deleted the deep-boosted-jets-rebase-94X branch November 15, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slava77 slava77 slava77 left review comments

Assignees
No one assigned
Labels
analysis-pending backport-ok comparison-available orp-approved pending-signatures reconstruction-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.
5 participants
@hqucms @cmsbuild @perrotta @slava77 @fabiocos