Seeding layers ESP to EDP migration #2378

Martin-Grunewald · 2014-02-10T12:34:26Z

Seeding layers ESP to EDP migration

Includes and superseeds for 71X both #2286 and #2308.

…s unused This simplifies further development of SeedingLayerSetsBuilder.

…ation

…nterface The old interface needs to be kept, because some classes use it with ctfseeding:SeedingLayer's constructed without SeedingLayersESProducer. I used templates in CosmicTrackingRegion and RectangularEtaPhiTrackingRegion to avoid copy-pasting.

…etsHits

…, MultiHitGeneratorFromChi2

In QuadrupletSeedMerger SeedingLayerSets are used only to iterate over layer-quadruplets. Therefore SeedingLayersEDProducer would mean unnecessary work by creating the TTRHs. Therefore I decided to just deliver the SeedingLayerSetsBuilder PSet to QuadrupletSeedMerger, and construct SeedingLayerSetsBuilder in the constructor.

Will need to deliver edm::ConsumesCollector to OrderedHitsGenerator in SeedFilter (to be added in a later commit). As a knock-on effect, move SeedFilter construction from beginRun() to constructor in ElectronSeedProducer. Also, use std::unique_ptr for SeedFilter.

Will be needed to deliver edm::ConsumesCollector to - CombinedHitPairGenerator - CombinedMultiHitGenerator - CombinedHitTripletGenerator - CombinedHitPairGeneratorForPhotonConversion - CombinedHitQuadrupletGeneratorForPhotonConversion Following concrete classes inherit from OrderedHitsGenerator - BeamHaloPairGenerator - GenericPairGenerator - GenericTripletGenerator - CombinedHitPairGenerator - CombinedMultiHitGenerator - CombinedHitTripletGenerator - CombinedHitPairGeneratorForPhotonConversion - CombinedHitQuadrupletGeneratorForPhotonConversion Knock-on effects: Pass ConsumesCollector to OrderedHitsFactory - TSGSmart + move construction of OrderedHitsGenerator to constructor - TSGFromL1Muon (from beginRun) - PixelTrackReconstruction (from beginRun) - HitTripletProducer (from init) - CtfSpecialSeedGenerator (from beginRun) - PhotonConversionTrajectorySeedProducerFromSingleLegAlgo (from init) - ConversionSeedGenerators/src/PhotonConversionTrajectorySeedProducerFromQuadrupletsAlgo (from init) + move construction of SeedGeneratorFromRegionHits to constructor - TSGFromOrderedHits - EgammaHLTRegionalPixelSeedGeneratorProducers + move construction of SeedComparitor and SeedCreator to constructor - SeedGeneratorFromRegionHitsEDProducer

Needed for edm::ConsumesCollector (in later commit).

Martin-Grunewald · 2014-02-17T13:46:44Z

Could AlCa please sign this PR so that it gets integrated? It is now one week....

cerati · 2014-02-17T17:50:42Z

I second the request of integrating this PR asap (it touches the whole tracking code and makes difficult for developers to avoid conflicts)

rcastello · 2014-02-18T16:16:15Z

+1
AlCa signed. sorry for the delay

ktf · 2014-02-19T08:00:53Z

RecoTracker/SeedingLayerSetsHits is a new package. Adding it to reco. Complain if not ok.

Reco updates -- Seeding layers ESP to EDP migration

davidlange6 · 2014-02-19T08:51:18Z

hum, maybe we don't need a new package for one class?

On Feb 19, 2014, at 9:00 AM, Giulio Eulisse notifications@github.com
wrote:

RecoTracker/SeedingLayerSetsHits is a new package. Adding it to reco. Complain if not ok.

—
Reply to this email directly or view it on GitHub.

makortel · 2014-02-19T09:00:31Z

The "one class" in the new package is a transient-only EDProduct depending on TransientTrackingRecHit. Given the restrictions in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts it was easiest to prototype in a new package. I'm of course happy to move the class to an existing package if there are better suggestions.

(maybe we should have had this discussion before merging? :)

davidlange6 · 2014-02-19T09:04:14Z

Thanks for the explanation Matti. maybe its best to move it together with TransientTrackingRecHit if that is what it depends on?

On Feb 19, 2014, at 10:00 AM, Matti Kortelainen notifications@github.com
wrote:

The "one class" in the new package is a transient-only EDProduct depending on TransientTrackingRecHit. Given the restrictions in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts it was easiest to prototype in a new package. I'm of course happy to move the class to an existing package if there are better suggestions.

(maybe we should have had this discussion before merging? :)

—
Reply to this email directly or view it on GitHub.

Martin-Grunewald · 2014-02-19T09:08:19Z

Hi,

Please do NOT unmerge. Make a new PR with only this change.
Otherwise we'll have to wait another week before all signatures are in.

Thanks and best regards

Martin

On Wed, 19 Feb 2014, davidlange6 wrote:

Thanks for the explanation Matti. maybe its best to move it together with TransientTrackingRecHit if that is what it depends on?

On Feb 19, 2014, at 10:00 AM, Matti Kortelainen notifications@github.com
wrote:

The "one class" in the new package is a transient-only EDProduct depending on TransientTrackingRecHit. Given the restrictions in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts it was easiest to prototype in a new package. I'm of course happy to move the class to an existing package if there are better suggestions.

(maybe we should have had this discussion before merging? :)

—
Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub:
#2378 (comment)

Martin

Martin W. Gruenewald e-mail: Martin.Grunewald@cern.ch
http://cern.ch/Martin.Grunewald

makortel · 2014-02-19T09:16:01Z

@davidlange6 Fine for me. I first though that SeedingLayerSetsHits class would not have that much to do with TransientTrackingRecHit (except of using it), but it could be though as a very specialized container of TransientTrackingRecHits. The only new package dependence to TrackingTools/TransientTrackingRecHit would be FWCore/MessageLogger, which I guess is fine.

@Martin-Grunewald I fully agree. At this stage a new PR with just the move would probably be easiest for everybody.

I'll start preparing a new PR to move the class to TrackingTools/TransientTrackingRecHit, so please scream if there are other opinions.

ktf · 2014-02-19T09:25:40Z

Indeed this was merged since everyone has to sign about this. With git we can easily drop packages.

davidlange6 · 2014-02-19T09:29:59Z

Matti, is there a big change in the number of packages that would now depend on the ttrh package?

On Feb 19, 2014, at 10:16 AM, "Matti Kortelainen" <notifications@github.com mailto:notifications@github.com> wrote:

@davidlange6 https://github.com/davidlange6 Fine for me. I first though that SeedingLayerSetsHits class would not have that much to do with TransientTrackingRecHit (except of using it), but it could be though as a very specialized container of TransientTrackingRecHits. The only new package dependence to TrackingTools/TransientTrackingRecHit would be FWCore/MessageLogger, which I guess is fine.

@Martin-Grunewaldhttps://github.com/Martin-Grunewald I fully agree. At this stage a new PR with just the move would probably be easiest for everybody.

I'll start preparing a new PR to move the class to TrackingTools/TransientTrackingRecHit, so please scream if there are other opinions.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2378#issuecomment-35479294.

makortel · 2014-02-19T09:51:23Z

David, do you mean through the dependence on SeedingLayerSetsHits? There should be no new packages depending on TTRH, because all packages now using SeedingLayerSetsHits used/depended on TTRH (directly or via some other package) already prior to #2378.

davidlange6 · 2014-02-19T10:15:39Z

Yes, that's what I meant. It seems then this package is indeed a good spot.

On Feb 19, 2014, at 10:51 AM, "Matti Kortelainen" <notifications@github.com mailto:notifications@github.com> wrote:

David, do you mean through the dependence on SeedingLayerSetsHits? There should be no new packages depending on TTRH, because all packages now using SeedingLayerSetsHits used/depended on TTRH (directly or via some other package) already prior to #2378 #2378.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2378#issuecomment-35481925.

makortel · 2014-02-19T11:51:16Z

Moved SeedingLayerSetsHits to TrackingTools/TransientTrackingRecHit package in PR #2527.

Reco updates -- Seeding layers ESP to EDP migration

makortel added 30 commits February 10, 2014 07:19

Remove hasPredefinedHitErrors member from SeedingLayer(SetsBuilder) a…

492a8a8

…s unused This simplifies further development of SeedingLayerSetsBuilder.

Remove useErrorsFromParam, hitErrorRZ, and hitErrorRPhi from configur…

ca34e46

…ation

Add SeedingLayerSetsHits for transient EDProduct of SeedingLayers

dc40c65

Add SeedingLayersEDProducer

05758c0

Migrate LayerHitMapCache to SeedingLayerSetsHits

d0e1c52

Migrate HitPairGeneratorFromLayerPair to SeedingLayerSetsHits

5675c03

Migrate CombinedHitPairGenerator to SeedingLayerSetsHits

7b31f99

Migrate LayerTriplets to SeedingLayerSetsHits

988d88f

Migrate HitTripletGeneratorFromPairAndLayers classes to SeedingLayerS…

36a366e

…etsHits

Migrate CombinedHitTripletGenerator to SeedingLayerSetsHits

2b61caa

Migrate CombinedMultiHitGenerator, MultiHitGeneratorFromPairAndLayers…

95abe58

…, MultiHitGeneratorFromChi2

Migrate configuration: TobTecLayerPairs_cfi

478826e

Migrate configuration: PixelLessLayerPairs_cfi

fe74c82

Migrate configuration: PixelLessLayerPairs4PixelLessTracking_cfi

5fbb1ec

Migrate configuration: PixelLayerTriplets_cfi

5125bec

Migrate configuration: PixelLayerPairs_cfi

9dfbbc6

Migrate configuration: PixelAndStripLayerPairs_cfi

b4d73c6

Migrate configuration: MixedLayerPairs_cfi

ee01c98

Migrate bunch of configuration files without any knock-on effects

2178d9a

Migrate conversion configuration files

5a1d728

Migrate configuration: thirdStep_cff

c56732c

Migrate configuration: secondStep_cff

a9355e1

Migrate EgammaHLTRegionalPixelSeedGeneratorProducers

bc6e6a0

Remove SeedingLayerESProducer as obsolete

ede1c91

Migrate SeedingLayerSetsHits consumers to getByToken

367c7d5

Construct HitExtractors in SeedingLayerSetsBuilder constructor

116c218

Needed for edm::ConsumesCollector (in later commit).

matteosan1 mentioned this pull request Feb 17, 2014

Finalize migration to consumes for RecoEgamma/EgammaHLT* #2497

Merged

ktf added a commit that referenced this pull request Feb 19, 2014

Merge pull request #2378 from Martin-Grunewald/SeedingLayers

43c72bc

Reco updates -- Seeding layers ESP to EDP migration

ktf merged commit 43c72bc into cms-sw:CMSSW_7_1_X Feb 19, 2014

makortel mentioned this pull request Feb 19, 2014

Move SeedingLayerSetsHits to TrackingTools/TransientTrackingRecHit package #2527

Merged

perrotta mentioned this pull request Feb 20, 2014

Seeding layers backported to 70X #2559

Closed

nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014

This was referenced Mar 5, 2014

Strip cluster #2466

Merged

Seeding layers for70 x #2728

Merged

nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014

makortel mentioned this pull request Mar 18, 2014

Remove TYPELOOKUP_DATA_REG(SeedingLayerSetsBuilder) #2919

Merged

Martin-Grunewald deleted the SeedingLayers branch April 1, 2014 05:12

makortel mentioned this pull request Feb 9, 2015

Phase1 (2015 + Pixel Phase1) Workflow up to Reco #7625

Closed

shervin86 pushed a commit to shervin86/cmssw that referenced this pull request May 11, 2015

Merge pull request cms-sw#2378 from Martin-Grunewald/SeedingLayers

83ef8cd

Reco updates -- Seeding layers ESP to EDP migration

makortel mentioned this pull request Nov 2, 2017

Cleanup and modernize SeedingLayerSetsBuilder #21138

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Seeding layers ESP to EDP migration #2378

Seeding layers ESP to EDP migration #2378

Martin-Grunewald commented Feb 10, 2014

Martin-Grunewald commented Feb 17, 2014

cerati commented Feb 17, 2014

rcastello commented Feb 18, 2014

ktf commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

makortel commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

Martin-Grunewald commented Feb 19, 2014

makortel commented Feb 19, 2014

ktf commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

makortel commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

makortel commented Feb 19, 2014

Seeding layers ESP to EDP migration #2378

Seeding layers ESP to EDP migration #2378

Conversation

Martin-Grunewald commented Feb 10, 2014

Martin-Grunewald commented Feb 17, 2014

cerati commented Feb 17, 2014

rcastello commented Feb 18, 2014

ktf commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

makortel commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

Martin-Grunewald commented Feb 19, 2014

makortel commented Feb 19, 2014

ktf commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

makortel commented Feb 19, 2014

davidlange6 commented Feb 19, 2014

makortel commented Feb 19, 2014