Revert "Do not truncate QIE11 linearization LUTs at 10 bits"

[christopheralanwest]

Backport #22848

This reverts commit 21db65c.

[cmsbuild]

A new Pull Request was created by @christopheralanwest for CMSSW_10_1_X.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos

@ghellwig, @cmsbuild, @arunhep, @cerminar, @nsmith-, @rekovic, @franzoni, @thomreis, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Revert "Do not truncate QIE11 linearization LUTs at 10 bits" #22848

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27283/console Started: 2018/04/05 00:19

[cmsbuild]

+1
Tested at: 97d9ec3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22849/27283/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22849/27283/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501879
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501702
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.09 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[abdoulline]

@christopheralanwest
Chris, this fix is highly desirable for data-taking (being prepared) 10_1_1, right?

[christopheralanwest]

@abdoulline Yes, this fix is very important for data-taking. Since the most significant bit of the LUT is being dropped, E_T is being computed in each sample modulo 64 GeV (or 32 GeV, depending on the region of HE). Modified LUTs generated with this patch are already online [1].

[1] http://cmsonline.cern.ch/cms-elog/1034555

[abdoulline]

@fabiocos
So I take the liberty to draw attention of Fabio to this PR for 10_1_1 ...

[fabiocos]

@abdoulline @deguio @christopheralanwest it is in the 10_1_1 list as you can see, it needs to be reviewed and integrated in master though...

[thomreis]

+1

[cmsbuild]

Pull request #22849 was updated. @ghellwig, @cmsbuild, @arunhep, @cerminar, @nsmith-, @rekovic, @franzoni, @thomreis, @lpernie can you please check and sign again.

[thomreis]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27367/console Started: 2018/04/07 09:23

[cmsbuild]

+1
Tested at: a09c77d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22849/27367/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22849/27367/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2504051
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2503874
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.20000000008 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1