-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add HCAL laser monitoring charge #21152
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
26b0854
add laser monitor charge to HcalNoiseSummary which is calculated in H…
0ef4b39
update to include fillDescriptions and the METFilter code
8141e8c
remove printout
f7507af
fix checksum, tabulation, and remove commented code
25362e6
remove remaining existsAs, fix hack in filling vectors
7a1a8f3
add code changes
87b187a
switch one int to unsigned, change continue to break
fec7361
switch to using cboxChannel instead of hcalSubdet to identify laser …
0a2d556
simplify the loop to determine matching time slices
81054d2
move last_ts to nts, instead of counting matches, just look for a mis…
52993b9
807 : start_ts = nts;
4d7e1df
remove all defaults in hcalnoiseinfoproducer_cfi, reorder and add com…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 1 addition & 125 deletions
126
RecoMET/METProducers/python/hcalnoiseinfoproducer_cfi.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,125 +1 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
HcalNoiseParameterSet = cms.PSet( | ||
# define hit energy thesholds | ||
minRecHitE = cms.double(1.5), | ||
minLowHitE = cms.double(10.0), | ||
minHighHitE = cms.double(25.0), | ||
minR45HitE = cms.double(5.0), | ||
|
||
# define energy threshold for "problematic" cuts | ||
pMinERatio = cms.double(25.0), | ||
pMinEZeros = cms.double(5.0), | ||
pMinEEMF = cms.double(10.0), | ||
|
||
# define energy threshold for loose/tight/high level cuts | ||
minERatio = cms.double(50.0), | ||
minEZeros = cms.double(10.0), | ||
minEEMF = cms.double(50.0), | ||
|
||
# define problematic RBX | ||
pMinE = cms.double(40.0), | ||
pMinRatio = cms.double(0.75), | ||
pMaxRatio = cms.double(0.85), | ||
pMinHPDHits = cms.int32(10), | ||
pMinRBXHits = cms.int32(20), | ||
pMinHPDNoOtherHits = cms.int32(7), | ||
pMinZeros = cms.int32(4), | ||
pMinLowEHitTime = cms.double(-6.0), | ||
pMaxLowEHitTime = cms.double(6.0), | ||
pMinHighEHitTime = cms.double(-4.0), | ||
pMaxHighEHitTime = cms.double(5.0), | ||
pMaxHPDEMF = cms.double(-0.02), | ||
pMaxRBXEMF = cms.double(0.02), | ||
pMinRBXRechitR45Count = cms.int32(1), | ||
pMinRBXRechitR45Fraction = cms.double(0.1), | ||
pMinRBXRechitR45EnergyFraction = cms.double(0.1), | ||
|
||
# define loose noise cuts | ||
lMinRatio = cms.double(-999.), | ||
lMaxRatio = cms.double(999.), | ||
lMinHPDHits = cms.int32(17), | ||
lMinRBXHits = cms.int32(999), | ||
lMinHPDNoOtherHits = cms.int32(10), | ||
lMinZeros = cms.int32(10), | ||
lMinLowEHitTime = cms.double(-9999.0), | ||
lMaxLowEHitTime = cms.double(9999.0), | ||
lMinHighEHitTime = cms.double(-9999.0), | ||
lMaxHighEHitTime = cms.double(9999.0), | ||
|
||
# define tight noise cuts | ||
tMinRatio = cms.double(-999.), | ||
tMaxRatio = cms.double(999.), | ||
tMinHPDHits = cms.int32(16), | ||
tMinRBXHits = cms.int32(50), | ||
tMinHPDNoOtherHits = cms.int32(9), | ||
tMinZeros = cms.int32(8), | ||
tMinLowEHitTime = cms.double(-9999.0), | ||
tMaxLowEHitTime = cms.double(9999.0), | ||
tMinHighEHitTime = cms.double(-7.0), | ||
tMaxHighEHitTime = cms.double(6.0), | ||
|
||
# define high level noise cuts | ||
hlMaxHPDEMF = cms.double(-9999.0), | ||
hlMaxRBXEMF = cms.double(0.01), | ||
|
||
# Calibration digi noise variables (used for finding laser noise events) | ||
calibdigiHBHEthreshold = cms.double(15), # minimum threshold in fC of any HBHE calib digi to be counted in summary | ||
calibdigiHBHEtimeslices=cms.vint32(3,4,5,6), # time slices to use when determining charge of HBHE calib digis | ||
calibdigiHFthreshold = cms.double(-999), # minimum threshold in fC of any HF calib digi to be counted in summary | ||
calibdigiHFtimeslices=cms.vint32(0,1,2,3,4,5,6,7,8,9), # time slices to use when determining charge of HF calib digis | ||
|
||
# RBX-wide TS4TS5 variable | ||
TS4TS5EnergyThreshold = cms.double(50), | ||
TS4TS5UpperThreshold = cms.vdouble(70, 90, 100, 400, 4000), | ||
TS4TS5UpperCut = cms.vdouble(1, 0.8, 0.75, 0.72, 0.72), | ||
TS4TS5LowerThreshold = cms.vdouble(100, 120, 150, 200, 300, 400, 500), | ||
TS4TS5LowerCut = cms.vdouble(-1, -0.7, -0.4, -0.2, -0.08, 0, 0.1), | ||
|
||
# rechit R45 population filter variables | ||
# this comes in groups of four: (a_Count, a_Fraction, a_EnergyFraction, const) | ||
# flag as noise if (count * a_count + fraction * a_fraction + energyfraction * a_energyfraction + const) > 0 | ||
lRBXRecHitR45Cuts = cms.vdouble(0.0, 1.0, 0.0, -0.5, # equivalent to "fraction > 0.5" | ||
0.0, 0.0, 1.0, -0.5), # equivalent to "energy fraction > 0.5" | ||
tRBXRecHitR45Cuts = cms.vdouble(0.0, 1.0, 0.0, -0.2, # equivalent to "fraction > 0.2" | ||
0.0, 0.0, 1.0, -0.2) # equivalent to "energy fraction > 0.2" | ||
) | ||
|
||
|
||
hcalnoise = cms.EDProducer( | ||
'HcalNoiseInfoProducer', | ||
|
||
# general noise parameters | ||
HcalNoiseParameterSet, | ||
|
||
# what to fill | ||
fillDigis = cms.bool(True), | ||
fillRecHits = cms.bool(True), | ||
fillCaloTowers = cms.bool(True), | ||
fillTracks = cms.bool(True), | ||
|
||
# maximum number of RBXs to fill | ||
# if you want to record all RBXs above some energy threshold, | ||
# change maxProblemRBXs to 999 and pMinE (above) to the threshold you want | ||
maxProblemRBXs = cms.int32(72), | ||
|
||
# parameters for calculating summary variables | ||
maxCaloTowerIEta = cms.int32(20), | ||
maxTrackEta = cms.double(2.0), | ||
minTrackPt = cms.double(1.0), | ||
maxNHF = cms.double(0.9), | ||
maxjetindex = cms.int32(0), | ||
|
||
# collection names | ||
digiCollName = cms.string('hcalDigis'), | ||
recHitCollName = cms.string('hbhereco'), | ||
caloTowerCollName = cms.string('towerMaker'), | ||
trackCollName = cms.string('generalTracks'), | ||
jetCollName = cms.string('ak4PFJets'), | ||
|
||
# severity level | ||
HcalAcceptSeverityLevel = cms.uint32(9), | ||
|
||
# which hcal calo flags to mask (HBHEIsolatedNoise=11, HBHEFlatNoise=12, HBHESpikeNoise=13, HBHETriangleNoise=14, HBHETS4TS5Noise=15, HBHENegativeNoise=27) | ||
HcalRecHitFlagsToBeExcluded = cms.vint32(11, 12, 13, 14, 15, 27) | ||
) | ||
from RecoMET.METProducers.hcalnoise_cfi import * # from fillDescriptions |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this variable is not initialized.
Since I've added the MET filter path monitoring a few days ago, now we find that this leads to random differences when reading AOD produced by a release before 100X.
E.g. #25320 (comment)
@perrotta