Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleScattering parameterization #19498

Merged
merged 22 commits into from
Jul 4, 2017
Merged

MultipleScattering parameterization #19498

merged 22 commits into from
Jul 4, 2017

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Jul 1, 2017

This PR introduces a test of the Navigation and a new parameterization of the MultipleScattering between layers.
Not yet in use...

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2017

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

RecoTracker/MeasurementDet
RecoTracker/Record
RecoTracker/TkNavigation
TrackingTools/GeomPropagators

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@VinInn
Copy link
Contributor Author

VinInn commented Jul 1, 2017

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21050/console Started: 2017/07/01 15:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19498/21050/summary.html

Comparison Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756063
  • DQMHistoTests: Total failures: 29842
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1726055
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2017

+1

  • Mostly tests, and code needed to derive those parameterizations
  • Standard workflows not affected, no effect on jenkins outputs
  • Local tests included in this PR run: whether the produced output is exactly what expected is hard to say not being expert of the code: anyhow, they reach their end without errors

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 63024c6 into cms-sw:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants