#clusters per layer and ring - TProfile2D #19396

gflouris · 2017-06-21T15:03:25Z

Change NumberOfClusterPerLayerTrendVar and NumberOfClusterPerRingVsTrendVar to TProfile2D.

cmsbuild · 2017-06-21T15:03:44Z

A new Pull Request was created by @gflouris (Giannis Flouris) for master.

It involves the following packages:

DQM/SiStripMonitorCluster

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

dmitrijus · 2017-06-23T13:09:52Z

please test

cmsbuild · 2017-06-23T13:10:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20879/console Started: 2017/06/23 15:12

cmsbuild · 2017-06-23T14:51:19Z

+1
Tested at: a071572
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/20879/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5ad2ca3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/20879/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/20879/git-merge-result

cmsbuild · 2017-06-23T14:51:22Z

Comparison job queued.

cmsbuild · 2017-06-23T17:22:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/20879/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1802072
DQMHistoTests: Total failures: 29399
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1772507
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

dmitrijus · 2017-06-27T11:53:12Z

+1

cmsbuild · 2017-06-27T11:53:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-06-28T07:16:08Z

DQM/SiStripMonitorCluster/src/SiStripMonitorCluster.cc

-	  std::pair<std::string,int32_t> det_ring_pair = folder_organizer.GetSubDetAndLayer(detid,tTopo,true);
-          fillME(layer_single.LayerNumberOfClusterPerRingTrend, trendVar, abs(det_ring_pair.second));
+          std::pair<std::string,int32_t> det_ring_pair = folder_organizer.GetSubDetAndLayer(detid,tTopo,true);
+          ncluster_ring[abs(det_ring_pair.second)] ++ ;


hi @gflouris - please use std::abs

@davidlange6 done.

cmsbuild · 2017-06-30T08:39:59Z

Pull request #19396 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

boudoul · 2017-07-04T14:20:20Z

Hi @dmitrijus , could you please review this PR ? Thanks

davidlange6 · 2017-07-04T14:22:24Z

please test

cmsbuild · 2017-07-04T14:23:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21139/console Started: 2017/07/04 16:31

cmsbuild · 2017-07-04T16:43:41Z

+1
Tested at: 63adfca
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/21139/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b1580cd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/21139/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/21139/git-merge-result

cmsbuild · 2017-07-04T16:43:44Z

Comparison job queued.

cmsbuild · 2017-07-04T18:08:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19396/21139/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1755253
DQMHistoTests: Total failures: 29798
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1725289
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

davidlange6 · 2017-07-05T08:34:17Z

merge

threus · 2017-07-11T12:30:35Z

@gflouris could you please back port this PR to 92X? It is needed for the online DQM, otherwise your changes don't get merged into the current production branch.
Thanks

#clusters per layer and ring - TProfile2D

a071572

cmsbuild added this to the CMSSW_9_2_X milestone Jun 21, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jun 21, 2017

gflouris mentioned this pull request Jun 21, 2017

#Clusters per ring and layer dmwm/deployment#506

Merged

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 23, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 23, 2017

smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 27, 2017

smuzaffar modified the milestone: CMSSW_9_3_X Jun 27, 2017

davidlange6 reviewed Jun 28, 2017

View reviewed changes

use std::abs

63adfca

cmsbuild added comparison-pending dqm-pending pending-signatures tests-pending and removed comparison-available dqm-approved fully-signed tests-approved labels Jun 30, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 4, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 4, 2017

cmsbuild merged commit f194090 into cms-sw:master Jul 5, 2017

gflouris mentioned this pull request Jul 19, 2017

Sistrip cluster mon 92x #19818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#clusters per layer and ring - TProfile2D #19396

#clusters per layer and ring - TProfile2D #19396

gflouris commented Jun 21, 2017

cmsbuild commented Jun 21, 2017

dmitrijus commented Jun 23, 2017

cmsbuild commented Jun 23, 2017 •

edited

Loading

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

dmitrijus commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

davidlange6 Jun 28, 2017

gflouris Jun 30, 2017

cmsbuild commented Jun 30, 2017

boudoul commented Jul 4, 2017

davidlange6 commented Jul 4, 2017

cmsbuild commented Jul 4, 2017 •

edited

Loading

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

davidlange6 commented Jul 5, 2017

threus commented Jul 11, 2017

#clusters per layer and ring - TProfile2D #19396

#clusters per layer and ring - TProfile2D #19396

Conversation

gflouris commented Jun 21, 2017

cmsbuild commented Jun 21, 2017

dmitrijus commented Jun 23, 2017

cmsbuild commented Jun 23, 2017 • edited Loading

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

dmitrijus commented Jun 27, 2017

cmsbuild commented Jun 27, 2017

davidlange6 Jun 28, 2017

Choose a reason for hiding this comment

gflouris Jun 30, 2017

Choose a reason for hiding this comment

cmsbuild commented Jun 30, 2017

boudoul commented Jul 4, 2017

davidlange6 commented Jul 4, 2017

cmsbuild commented Jul 4, 2017 • edited Loading

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

davidlange6 commented Jul 5, 2017

threus commented Jul 11, 2017

cmsbuild commented Jun 23, 2017 •

edited

Loading

cmsbuild commented Jul 4, 2017 •

edited

Loading