fix some ranges/binning of plots in Phase 1 DQM #19103
Conversation
|
A new Pull Request was created by @fioriNTU for master. It involves the following packages: DQM/SiPixelPhase1Clusters @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
dqm-pending
pending-signatures
tests-pending
and removed
dqm-approved
fully-signed
tests-started
labels
|
Pull request #19103 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Comparison job queued. |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
hi @fioriNTU @dmitrijus - seems this added 20MB of histograms. Is that correct/ |
|
@davidlange I will check, in principle I think to have been fair in extending/reducing the binning of histograms, no real new histogram is added there |
|
ok, someone added 20MB of pixel histograms since 921... I suspect its this one.
… On Jun 14, 2017, at 10:15 AM, fioriNTU ***@***.***> wrote:
@davidlange I will check, in principle I think to have been fair in extending/reducing the binning of histograms, no real new histogram is added there
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange if this is only a suspect, I think that the PR that added more Phase1 histograms lately is this one #19059 , Mia deleted accidentally a large number of TProfiles from the regular Phase 1 DQM when introducing the HLTPixelDQM. This can add 20MB of stuff. |
|
can be - i was only guessing..
… On Jun 14, 2017, at 10:23 AM, fioriNTU ***@***.***> wrote:
@davidlange if this is only a suspect, I think that the PR that added more Phase1 histograms lately is this one #19059 , Mia deleted accidentally a large number of TProfiles from the regular Phase 1 DQM when introducing the HLTPixelDQM. This can add 20MB of stuff.
Anyway I am checking by my side.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@davidlange6 it looks like this PR doesn't add the 20MB of histos, I ran the 10024 workflow with and without and the filesize is the same 87MB in both cases |
This PR adjust some ranges to match the present and future running conditions.
Also disable the computation of row and col starting by the rec-hit position, that couse some jittering effect in the bin population