Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clashes between translator function in PythonModule.h/.cc #18786

Merged
merged 1 commit into from
May 18, 2017

Commits on May 17, 2017

  1. Fix clashes between translator function in PythonModule.h/.cc

    We have two global TU-local 'translator' functions in CMSSW:
    One is in PythonModule.cc and one is in PythonModule.h.
    
    While having TU-local functions in a header is already not recommended,
    having them defined twice with the same name like this is causing
    undefined behavior that breaks the linker (and also the rest
    of clang in the future once someone includes the wrong file).
    
    This patch is making the name of the header function unique to prevent
    future compiler errors.
    Teemperor committed May 17, 2017
    Configuration menu
    Copy the full SHA
    db921f6 View commit details
    Browse the repository at this point in the history